make Box::operator== virtual so that we can implement efficient compa…

…risons (see Box_ispe)
strukturag · Jun 10, 2024 · 47fcf6e · 47fcf6e
1 parent 1e75661
commit 47fcf6e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/libheif/box.cc b/libheif/box.cc
@@ -2169,6 +2169,18 @@ Error Box_ispe::write(StreamWriter& writer) const
 }
 
 
+bool Box_ispe::operator==(const Box& other) const
+{
+  const auto* other_ispe = dynamic_cast<const Box_ispe*>(&other);
+  if (other_ispe == nullptr) {
+    return false;
+  }
+
+  return (m_image_width == other_ispe->m_image_width &&
+          m_image_height == other_ispe->m_image_height);
+}
+
+
 Error Box_ipma::parse(BitstreamRange& range)
 {
   parse_full_box_header(range);

diff --git a/libheif/box.h b/libheif/box.h
@@ -196,7 +196,7 @@ class Box : public BoxHeader
 
   int find_or_append_child_box(const std::shared_ptr<Box>& box);
 
-  bool operator==(const Box& other) const;
+  virtual bool operator==(const Box& other) const;
 
   static bool equal(const std::shared_ptr<Box>& box1, const std::shared_ptr<Box>& box2);
 
@@ -584,6 +584,8 @@ class Box_ispe : public FullBox
 
   Error write(StreamWriter& writer) const override;
 
+  bool operator==(const Box& other) const override;
+
 protected:
   Error parse(BitstreamRange& range) override;