Fixed a regression where reader-node-role was changed to dev by d…

…efault, putting back the default `geth` value.

CHANGELOG.md

@@ -4,17 +4,21 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). See [MAINTAINERS.md](./MAINTAINERS.md)
 for instructions to keep up to date.
 
+# v1.4.22
+
+* Fixed a regression where `reader-node-role` was changed to `dev` by default, putting back the default `geth` value.
+
 # v1.4.21
 
-* bump substreams to `v1.1.20` with a fix for some minor bug fixes related to start block processing 
+* bump substreams to `v1.1.20` with a fix for some minor bug fixes related to start block processing
 
 # v1.4.20
 
 ## Added
 
 * added `tools poll-rpc-blocks` command to launch an RPC-based poller that acts as a firehose extractor node, printing base64-encoded protobuf blocks to stdout (used by the 'dev' node-type). It creates "light" blocks, without traces and ordinals.
-* added `--dev` flag to the `start` command to simplify running a local firehose+substreams stack from a development node (ex: Hardhat). 
-  * This flag overrides the `--reader-node-path`, instead pointing to the fireeth binary itself. 
+* added `--dev` flag to the `start` command to simplify running a local firehose+substreams stack from a development node (ex: Hardhat).
+  * This flag overrides the `--reader-node-path`, instead pointing to the fireeth binary itself.
   * This flag overrides the `--reader-node-type`, setting it to `dev` instead of `geth`.
     This node type has the following default `reader-node-arguments`: `tools poll-rpc-blocks http://localhost:8545 0`
   * It also removes `node` from the list of default apps

cmd/fireeth/cli/node.go

@@ -306,7 +306,7 @@ func registerCommonNodeFlags(cmd *cobra.Command, isReader bool) {
 	}
 
 	cmd.Flags().String(prefix+"path", "geth", "command that will be launched by the node manager (ignored on type 'dev')")
-	cmd.Flags().String(prefix+"type", "dev", "one of: ['dev', 'geth','openethereum']")
+	cmd.Flags().String(prefix+"type", "geth", "one of: ['dev', 'geth','openethereum']")
 	cmd.Flags().String(prefix+"arguments", "", "If not empty, overrides the list of default node arguments (computed from node type and role). Start with '+' to append to default args instead of replacing. You can use the {public-ip} token, that will be matched against space-separated hostname:IP pairs in PUBLIC_IPS env var, taking hostname from HOSTNAME env var.")
 	cmd.Flags().String(prefix+"data-dir", "{sf-data-dir}/{node-role}/data", "Directory for node data ({node-role} is either reader, peering or dev-miner)")
 	cmd.Flags().String(prefix+"ipc-path", "{sf-data-dir}/{node-role}/ipc", "IPC path cannot be more than 64chars on geth")