Skip to content

Commit

Permalink
add some context
Browse files Browse the repository at this point in the history
  • Loading branch information
fschoell committed Mar 22, 2024
1 parent 34f272e commit 8741180
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ If you were at `firehose-core` version `1.0.0` and are bumping to `1.1.0`, you s

## Unreleased

* Added `--merger-delete-threads` to customize the number of threads the merger will use to delete files.
* Added `--merger-delete-threads` to customize the number of threads the merger will use to delete files. It's recommended to increase this when using Ceph as S3 storage provider to 25 or higher (due to performance issues with deletes the merger might otherwise not be able to delete one-block files fast enough).

## v1.2.5

Expand Down
2 changes: 1 addition & 1 deletion cmd/apps/merger.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func RegisterMergerApp(rootLog *zap.Logger) {
cmd.Flags().Uint64("merger-stop-block", 0, "If non-zero, merger will trigger shutdown when blocks have been merged up to this block")
cmd.Flags().Duration("merger-time-between-store-lookups", 1*time.Second, "Delay between source store polling (should be higher for remote storage)")
cmd.Flags().Duration("merger-time-between-store-pruning", time.Minute, "Delay between source store pruning loops")
cmd.Flags().Int("merger-delete-threads", 8, "Number of threads for deleting files in parallel.")
cmd.Flags().Int("merger-delete-threads", 8, "Number of threads for deleting files in parallel (increase this in case the merger isn't able to keep up with deleting one-block files).")
return nil
},
FactoryFunc: func(runtime *launcher.Runtime) (launcher.App, error) {
Expand Down

0 comments on commit 8741180

Please sign in to comment.