Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added effects and turned off interactions for continuous behavior #109

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

nynkeniezink
Copy link
Collaborator

@nynkeniezink nynkeniezink commented Nov 10, 2024

Description

  • New effects varAlt and avSimVarAlt added.
  • Bug correction: Interaction effects for continuous behavior now turned
    off. The R side of includeInteraction for continuous behavior had been
    implemented but not the C++ side, so now an error message is given.
  • Error message: If includeInteraction() is called for a continuous behavior
    effect, an error message is given that interaction effects are not yet
    implemented for continuous behavior.
  • Coding: For the new effects, lvariance, the behavior variance over all but
    the last wave, was included as member data of BehaviorLongitudinalData
    together with the corresponding member functions.

Checklist:

Checks

  • If possible, I have added tests that prove my fix is effective or that my feature works
  • The package builds on my OS without issues
  • My changes generate no new warnings

Documentation

  • I have commented my code inline, particularly in hard-to-understand areas
  • If function added/modified, I have added/modified documentation (in .R file)
  • If effect added/modified, I have added/modified section 12 of the manual
  • I have added a description of all changes to this pull request above and to the NEWS.md file
  • I have bumped the version in the DESCRIPTION and man/RSiena-package.md files by the appropriate increment:
    • 'major' (incompatible API changes)
    • 'minor' (add functionality in a backwards compatible manner)
    • 'patch' (backwards compatible bug fixes)

@nynkeniezink nynkeniezink added the enhancement New feature or request label Nov 10, 2024
Copy link
Collaborator

@TomSnijders TomSnijders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave specific comments on some of the changed files.

Copy link
Collaborator Author

@nynkeniezink nynkeniezink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replied to your specific comments on some of the changed files.

Copy link
Collaborator

@TomSnijders TomSnijders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now have seen all. There is one remaining question, about the sqrt version of the new outindegreebalance effect.

Copy link
Collaborator

@TomSnijders TomSnijders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful.

@TomSnijders TomSnijders merged commit c0c965a into main Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants