Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for stm32F407IGHx #2649

Merged
merged 1 commit into from
Feb 5, 2025
Merged

add support for stm32F407IGHx #2649

merged 1 commit into from
Feb 5, 2025

Conversation

hlgzhx
Copy link
Contributor

@hlgzhx hlgzhx commented Feb 3, 2025 •
edited by fpistm
Loading

Summary

add support for Generic STM32F407IGHx boards by editing boards.txt and add variants/STM32F4xx/F407I(E-G)(H-T)_F417I(E-G)(H-T)/ldscript.ld

屏幕截图(1)
compile test is passed,my board is in school but school is closed.if you need further test on uploading,please wait me to get back to school after Chinese new year.

im glad to fix further issues on supporting stm32f407ighx boards

Fixes #2589.
Fixes #2131.

@fpistm fpistm added the new variant Add support of new bard label Feb 3, 2025
@fpistm fpistm marked this pull request as draft February 3, 2025 13:57
fpistm
fpistm requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hlgzhx
Thanks for the PR anyway, it is not complete.
see my comments.
Moreover, please reference the mcu added in the README.md and add a default SystemClock_Config in the generic_clock.c.

See the Wiki for all steps:
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Add-a-new-variant-%28board%29

@fpistm fpistm linked an issue Feb 4, 2025 that may be closed by this pull request
[New Variant] STM32F407IGH #2589
Closed
@hlgzhx @fpistm
variant(f4): add generic F407I(E-G)(H-T) and F417I(E-G)(H-T)
d54d5f7 
Fixes stm32duino#2131.
Fixes stm32duino#2589.

Signed-off-by: Steve76427 <xcr060325@163.com>
Co-Authored-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm force-pushed the feature/add-f407igh branch from 16cbc1a to d54d5f7 Compare February 5, 2025 08:48
@fpistm fpistm marked this pull request as ready for review February 5, 2025 08:49
fpistm
fpistm approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hlgzhx
I've updated the PR with all my comments.

@fpistm fpistm mentioned this pull request Feb 5, 2025
Open
84 tasks
@fpistm fpistm merged commit 3510e4c into stm32duino:main Feb 5, 2025
24 of 25 checks passed
@hlgzhx
Copy link
Contributor Author

hlgzhx commented Feb 6, 2025

wow really thanks for your help.^_^

@fpistm
Copy link
Member

fpistm commented Feb 6, 2025

welcome @hlgzhx
If you can test on your side but I'm confident it works.

@hlgzhx
Copy link
Contributor Author

hlgzhx commented Feb 6, 2025

ok，these days i was just waiting to get to my boards and finish the test so i didn‘t submit further correction.I'm also sure your code will work well.xD

@fpistm
Copy link
Member

fpistm commented Feb 6, 2025

ok，these days i was just waiting to get to my boards and finish the test so i didn‘t submit further correction.I'm also sure your code will work well.xD

I hope :)

@hlgzhx
Copy link
Contributor Author

hlgzhx commented Feb 8, 2025

thanks for your help. i've tested it on my board,it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
STM32 core based on ST HAL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Variant] STM32F407IGH [New Variant] does this lib support STM32F407IGT6?
2 participants
@hlgzhx @fpistm