Merge pull request #16 from stfc/fix-hypervisor-uptime-less-than-day

Handle uptime days is 1
stfc · Feb 13, 2025 · fc34ccf · fc34ccf
2 parents 5d65e72 + 3687ef5
commit fc34ccf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/openstackquery/time_utils.py b/openstackquery/time_utils.py
@@ -69,11 +69,12 @@ def extract_uptime(uptime_string: str) -> Optional[float]:
         if match:
             uptime_string = match.group(1)
             days = 0
-            if "days" in uptime_string:
-                days_part, time_part = uptime_string.split(" days, ")
+            time_part = uptime_string
+            if "day" in uptime_string:
+                days_part, time_part = uptime_string.split(
+                    " day" + ("s" if "days" in uptime_string else "") + ", "
+                )
                 days += int(days_part)
-            else:
-                time_part = uptime_string
 
             hours, minutes = map(int, time_part.split(":"))
             days += hours / 24 + minutes / 1440

diff --git a/tests/test_time_utils.py b/tests/test_time_utils.py
@@ -112,3 +112,13 @@ def test_extract_uptime_less_than_day():
     res = TimeUtils.extract_uptime(mock_string)
 
     assert res == 0.25
+
+
+def test_extract_uptime_is_one_day():
+    """
+    Test extraction when less than a day uptime
+    """
+    mock_string = "17:13:49 up 1 day,  7:03,  0 users,  load average: 0.00, 0.01, 0.00"
+    res = TimeUtils.extract_uptime(mock_string)
+
+    assert res == 1.29