-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockifier): add NativeSyscallHandler
#549
feat(blockifier): add NativeSyscallHandler
#549
Conversation
# Conflicts: # crates/blockifier/src/execution/syscalls/syscalls_test.rs
…-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock
…cution-engine # Conflicts: # Cargo.lock # crates/blockifier/src/execution/contract_class.rs
NativeSyscallHandler
NativeSyscallHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 22 files at r1, all commit messages.
Reviewable status: 18 of 22 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 22 files at r1.
Reviewable status: 19 of 22 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 22 files at r1.
Reviewable status: 20 of 22 files reviewed, 1 unresolved discussion (waiting on @varex83)
crates/blockifier/src/execution/native/utils_test.rs
line 29 at r1 (raw file):
let res = decode_felts_as_str(&felts); dbg!(res.as_bytes());
Is the print here intentional? If so, what is its purpose?
Code quote:
dbg!(res.as_bytes());
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 22 files at r1.
Reviewable status: 21 of 22 files reviewed, 1 unresolved discussion (waiting on @varex83)
…call-handler # Conflicts: # crates/blockifier/src/execution/native/utils.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 16 of 22 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/execution/native/utils_test.rs
line 29 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Is the print here intentional? If so, what is its purpose?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r3, 2 of 4 files at r4, all commit messages.
Reviewable status: 20 of 22 files reviewed, all discussions resolved
Solved in #1240 |
This PR is follow-up after #429
This change is