Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): add NativeSyscallHandler #549

Closed

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Aug 21, 2024

This PR is follow-up after #429


This change is Reviewable

varex83 added 27 commits August 6, 2024 19:00
# Conflicts:
#	crates/blockifier/src/execution/syscalls/syscalls_test.rs
…cution-engine

# Conflicts:
#	Cargo.lock
#	crates/blockifier/src/execution/contract_class.rs
@varex83 varex83 changed the title Add NativeSyscallHandler feat(blockifier): add NativeSyscallHandler Aug 21, 2024
Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 22 files at r1, all commit messages.
Reviewable status: 18 of 22 files reviewed, all discussions resolved

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 22 files at r1.
Reviewable status: 19 of 22 files reviewed, all discussions resolved

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 22 files at r1.
Reviewable status: 20 of 22 files reviewed, 1 unresolved discussion (waiting on @varex83)


crates/blockifier/src/execution/native/utils_test.rs line 29 at r1 (raw file):

    let res = decode_felts_as_str(&felts);
    dbg!(res.as_bytes());

Is the print here intentional? If so, what is its purpose?

Code quote:

   dbg!(res.as_bytes());

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 22 files at r1.
Reviewable status: 21 of 22 files reviewed, 1 unresolved discussion (waiting on @varex83)

Copy link
Contributor Author

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 16 of 22 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/blockifier/src/execution/native/utils_test.rs line 29 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Is the print here intentional? If so, what is its purpose?

Done.

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r3, 2 of 4 files at r4, all commit messages.
Reviewable status: 20 of 22 files reviewed, all discussions resolved

@rodrigo-pino rodrigo-pino added the native integration Related with the integration of Cairo Native into the Blockifier label Sep 23, 2024
@rodrigo-pino
Copy link
Contributor

Solved in #1240

@rodrigo-pino rodrigo-pino deleted the native/add-syscall-handler branch October 10, 2024 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants