feat(starknet_os): bucket element of 252 bits is felt #4642
+99
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dorimedini-starkware
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/pack_usize_in_felt
branch
from
8e797d5 to
7a22197
Compare
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/bucket_element_252
branch
from
1797efd to
610d50d
Compare
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/pack_usize_in_felt
branch
from
7a22197 to
e1e6492
Compare
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/bucket_element_252
branch
from
610d50d to
03a0683
Compare
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/pack_usize_in_felt
branch
from
e1e6492 to
b197099
Compare
yoavGrs
force-pushed
the
yoav/snos/hints/compression_hint/bucket_element_252
branch
from
03a0683 to
90dd1b3
Compare
yoavGrs
changed the base branch from
yoav/snos/hints/compression_hint/pack_usize_in_felt
to
main
|
Artifacts upload workflows: |
|
Benchmark movements: |
dorimedini-starkware
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.