feat(starknet_os): implement hint cache_contract_storage_request_key

[aner-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/error.rs line 34 at r2 (raw file):

    InconsistentValue { actual: Felt, expected: Felt },
    #[error(transparent)]
    StarknetApi(#[from] StarknetApiError),

keep these alphabetized

Code quote:

    #[error("{error:?} for json value {value}.")]
    SerdeJsonError { error: serde_json::Error, value: serde_json::value::Value },
    #[error("Inconsistent storage value. Actual: {actual}, expected: {expected}.")]
    InconsistentValue { actual: Felt, expected: Felt },
    #[error(transparent)]
    StarknetApi(#[from] StarknetApiError),

---

crates/starknet_os/src/hints/vars.rs line 54 at r2 (raw file):

    CompressedStart,
    ContractStateChanges,
    ContractAddress,

Suggestion:

    ContractAddress,
    ContractStateChanges,

---

crates/starknet_os/src/hints/vars.rs line 80 at r2 (raw file):

            Ids::CompressedStart => "compressed_start",
            Ids::ContractStateChanges => "contract_state_changes",
            Ids::ContractAddress => "contract_address",

swap order

Code quote:

            Ids::ContractStateChanges => "contract_state_changes",
            Ids::ContractAddress => "contract_address",

[aner-starkware]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware)

---

crates/starknet_os/src/hints/error.rs line 34 at r2 (raw file):

Previously, dorimedini-starkware wrote…

keep these alphabetized

Done.

---

crates/starknet_os/src/hints/vars.rs line 80 at r2 (raw file):

Previously, dorimedini-starkware wrote…

swap order

Done.

---

crates/starknet_os/src/hints/vars.rs line 54 at r2 (raw file):

    CompressedStart,
    ContractStateChanges,
    ContractAddress,

Done.

[nimrod-starkware]

Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

        ids_data,
        Ids::Request,
        CairoStruct::DictAccess,

This isn't the right type, the type is StorageReadRequest*.
The function i wrote does not support the case where the base struct is a pointer.
Let me first solve it

Code quote:

CairoStruct::DictAccess

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

Previously, nimrod-starkware wrote…

This isn't the right type, the type is StorageReadRequest*.
The function i wrote does not support the case where the base struct is a pointer.
Let me first solve it

WDYM? don't you support it? you have logic to remove the * and dereference, no?

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

Previously, dorimedini-starkware wrote…

WDYM? don't you support it? you have logic to remove the * and dereference, no?

But it works only for the nested fields

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

Previously, nimrod-starkware wrote…

But it works only for the nested fields

If i have for example ids.x.y
and x is a pointer, adding the offset of y won't give me anything.

[aner-starkware]

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

Previously, nimrod-starkware wrote…

If i have for example ids.x.y
and x is a pointer, adding the offset of y won't give me anything.

@nimrod-starkware you mean like this? If not, how do I make a pointer type?

[nimrod-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @dorimedini-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 323 at r2 (raw file):

Previously, aner-starkware wrote…

@nimrod-starkware you mean like this? If not, how do I make a pointer type?

exactly :)

[dorimedini-starkware]

Reviewed 1 of 2 files at r6, 2 of 2 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)