feat(blockifier): version bound accounts: add max tip #4618
+112
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
liorgold2
commented
Mar 3, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion
crates/blockifier/resources/blockifier_versioned_constants_0_14_0.json line 127 at r1 (raw file):
"0x04c6d6cf894f8bc96bb9c525e6853e5483177841f7388f74a46cfda6f028c755" ], "v1_bound_accounts_max_tip": "0x1000"
This value needs to be fixed.
liorgold2
force-pushed
the
lior/version-0
branch
from
ebc1306 to
2da31fc
Compare
There was a problem hiding this comment.
Reviewed 10 of 14 files at r1, all commit messages.
Reviewable status: 10 of 14 files reviewed, 1 unresolved discussion
liorgold2
force-pushed
the
lior/version-0
branch
from
2da31fc to
1da9a7c
Compare
Yoni-Starkware
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Reviewed 3 of 14 files at r1.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion
liorgold2
force-pushed
the
lior/version-0
branch
from
1da9a7c to
4abc963
Compare
liorgold2
force-pushed
the
lior/version-0
branch
from
4abc963 to
78dacc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.