Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blockifier): add deploy call data factor to vc #4606

Open
wants to merge 2 commits into
base: main-v0.13.5
Choose a base branch
from

Conversation

AvivYossef-starkware
Copy link
Contributor

Cherry-pick to v0.13.5

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/cherry_pick_deploy_call_data_factor branch from 0a7a513 to 5a3b85f Compare March 3, 2025 13:06
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@AvivYossef-starkware AvivYossef-starkware changed the title feat(blockifier): add deploy call data factor to vc feat(blockifier): add deploy call data factor to vc Mar 3, 2025
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/cherry_pick_deploy_call_data_factor branch from 5a3b85f to 6d7ea19 Compare March 4, 2025 07:01
Copy link
Contributor Author

AvivYossef-starkware commented Mar 4, 2025

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/cherry_pick_deploy_call_data_factor branch 2 times, most recently from c705ad7 to 2603962 Compare March 4, 2025 15:10
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants