feat(blockifier): add config- allowlist of contracts to compile natively #4552
Conversation
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
avivg-starkware
force-pushed
the
avivg/blockifier/native_compile_multiple_contracts
branch
from
e742340 to
c07fc80
Compare
avivg-starkware
changed the title
avivg-starkware
force-pushed
the
avivg/blockifier/native_compile_multiple_contracts
branch
3 times, most recently
from
b47b6c5 to
b9fadaa
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
crates/blockifier/src/blockifier/config.rs line 190 at r1 (raw file):
ParamPrivacyInput::Public, )]); dump
I am unsure about this change - whether ser_optional_param is preferable here.
I am especially concerned about not being able to differentiate while looking at the config JSON between an empty list and None
Code quote:
dump.extend([ser_param(
"contract_to_compile_natively",
&serialize_optional_vec_class_hash(&self.contract_to_compile_natively),
"Contracts to compile natively (None means all).",
ParamPrivacyInput::Public,
)]);
dump
avivg-starkware
requested review from
noaov1,
AvivYossef-starkware and
meship-starkware
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1)
avivg-starkware
changed the base branch from
avivg/blockifier/contract_to_compile_natively
to
graphite-base/4552
avivg-starkware
force-pushed
the
graphite-base/4552
branch
from
5615d50 to
c9a99a5
Compare
avivg-starkware
force-pushed
the
avivg/blockifier/native_compile_multiple_contracts
branch
from
b9fadaa to
09f6611
Compare
avivg-starkware
changed the base branch from
graphite-base/4552
to
avivg/blockifier/contract_to_compile_natively
No description provided.