-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_os): enum for sized bucket elements #4546
feat(starknet_os): enum for sized bucket elements #4546
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
crates/starknet_os/src/hints/hint_implementation/stateless_compression/utils.rs
line 185 at r1 (raw file):
BitLength::Bits83 => BucketElement::BucketElement83(felt.try_into().unwrap()), BitLength::Bits125 => BucketElement::BucketElement125(felt.try_into().unwrap()), BitLength::Bits252 => BucketElement::BucketElement252(felt.try_into().unwrap()),
we may disallow unwrap
s in the future in non-test code; please change to expect
s
Code quote:
BitLength::Bits15 => BucketElement::BucketElement15(felt.try_into().unwrap()),
BitLength::Bits31 => BucketElement::BucketElement31(felt.try_into().unwrap()),
BitLength::Bits62 => BucketElement::BucketElement62(felt.try_into().unwrap()),
BitLength::Bits83 => BucketElement::BucketElement83(felt.try_into().unwrap()),
BitLength::Bits125 => BucketElement::BucketElement125(felt.try_into().unwrap()),
BitLength::Bits252 => BucketElement::BucketElement252(felt.try_into().unwrap()),
4dabbca
to
9bfb4ac
Compare
533d50d
to
12ff72a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os/src/hints/hint_implementation/stateless_compression/utils.rs
line 185 at r1 (raw file):
Previously, dorimedini-starkware wrote…
we may disallow
unwrap
s in the future in non-test code; please change toexpect
s
Done.
12ff72a
to
8dbd4f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
9bfb4ac
to
90226d6
Compare
8dbd4f6
to
98b57e6
Compare
90226d6
to
ca28abc
Compare
98b57e6
to
d32c0c1
Compare
ca28abc
to
4d8a4b9
Compare
d32c0c1
to
fc229a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
fc229a0
to
54ab727
Compare
No description provided.