Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_os): enum for sized bucket elements #4546

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Feb 27, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@yoavGrs yoavGrs self-assigned this Feb 27, 2025
@yoavGrs yoavGrs marked this pull request as ready for review February 27, 2025 15:57
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)


crates/starknet_os/src/hints/hint_implementation/stateless_compression/utils.rs line 185 at r1 (raw file):

            BitLength::Bits83 => BucketElement::BucketElement83(felt.try_into().unwrap()),
            BitLength::Bits125 => BucketElement::BucketElement125(felt.try_into().unwrap()),
            BitLength::Bits252 => BucketElement::BucketElement252(felt.try_into().unwrap()),

we may disallow unwraps in the future in non-test code; please change to expects

Code quote:

            BitLength::Bits15 => BucketElement::BucketElement15(felt.try_into().unwrap()),
            BitLength::Bits31 => BucketElement::BucketElement31(felt.try_into().unwrap()),
            BitLength::Bits62 => BucketElement::BucketElement62(felt.try_into().unwrap()),
            BitLength::Bits83 => BucketElement::BucketElement83(felt.try_into().unwrap()),
            BitLength::Bits125 => BucketElement::BucketElement125(felt.try_into().unwrap()),
            BitLength::Bits252 => BucketElement::BucketElement252(felt.try_into().unwrap()),

@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_trait branch from 4dabbca to 9bfb4ac Compare March 2, 2025 11:49
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from 533d50d to 12ff72a Compare March 2, 2025 11:50
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os/src/hints/hint_implementation/stateless_compression/utils.rs line 185 at r1 (raw file):

Previously, dorimedini-starkware wrote…

we may disallow unwraps in the future in non-test code; please change to expects

Done.

@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from 12ff72a to 8dbd4f6 Compare March 2, 2025 12:01
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_trait branch from 9bfb4ac to 90226d6 Compare March 2, 2025 12:44
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from 8dbd4f6 to 98b57e6 Compare March 2, 2025 12:44
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_trait branch from 90226d6 to ca28abc Compare March 2, 2025 13:36
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from 98b57e6 to d32c0c1 Compare March 2, 2025 13:36
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_trait branch from ca28abc to 4d8a4b9 Compare March 2, 2025 14:07
@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from d32c0c1 to fc229a0 Compare March 2, 2025 14:09
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/snos/hints/compression_hint/bucket_element_enum branch from fc229a0 to 54ab727 Compare March 2, 2025 15:46
@yoavGrs yoavGrs changed the base branch from yoav/snos/hints/compression_hint/bucket_element_trait to main March 2, 2025 15:46
@yoavGrs yoavGrs added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit f7e7b8d Mar 2, 2025
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants