-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open new branch: 0.13.5 #4544
open new branch: 0.13.5 #4544
Conversation
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)
a discussion (no related file):
blocking so it won't be merged
aaca972
to
297f27a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 6 files at r2, all commit messages.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @noaov1)
crates/blockifier/src/versioned_constants.rs
line 121 at r1 (raw file):
(V0_13_3, "../resources/versioned_constants_0_13_3.json"), (V0_13_4, "../resources/versioned_constants_0_13_4.json"), (V0_13_5, "../resources/versioned_constants_0_13_5.json"),
why was this and others reverted...?
Code quote:
(V0_13_5, "../resources/versioned_constants_0_13_5.json"),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)
crates/blockifier/src/versioned_constants.rs
line 121 at r1 (raw file):
Previously, dorimedini-starkware wrote…
why was this and others reverted...?
I opened a PR to fix it. See #4548 .
Benchmark movements: |
No description provided.