Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open new branch: 0.13.5 #4544

Closed
wants to merge 2 commits into from
Closed

open new branch: 0.13.5 #4544

wants to merge 2 commits into from

Conversation

noaov1
Copy link
Collaborator

@noaov1 noaov1 commented Feb 27, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Feb 27, 2025

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)


a discussion (no related file):
blocking so it won't be merged

@noaov1 noaov1 force-pushed the main-v0.13.5 branch 2 times, most recently from aaca972 to 297f27a Compare February 27, 2025 17:02
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r2, all commit messages.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @noaov1)


crates/blockifier/src/versioned_constants.rs line 121 at r1 (raw file):

    (V0_13_3, "../resources/versioned_constants_0_13_3.json"),
    (V0_13_4, "../resources/versioned_constants_0_13_4.json"),
    (V0_13_5, "../resources/versioned_constants_0_13_5.json"),

why was this and others reverted...?

Code quote:

(V0_13_5, "../resources/versioned_constants_0_13_5.json"),

Copy link
Collaborator Author

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)


crates/blockifier/src/versioned_constants.rs line 121 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why was this and others reverted...?

I opened a PR to fix it. See #4548 .

Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.927 ms 35.433 ms 36.038 ms]
change: [+1.1848% +2.7354% +4.5030%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) high mild
8 (8.00%) high severe

@noaov1 noaov1 closed this Mar 2, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants