feat(starknet_os): implement hint write_old_block_to_storage

[aner-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-03-04T08:17:28Z
• Started at 2025-03-04T09:07:00Z
• Started at 2025-03-04T09:27:07Z
• Started at 2025-03-04T09:37:26Z
• Started at 2025-03-04T15:06:46Z
• Started at 2025-03-04T15:08:44Z
• Started at 2025-03-04T15:48:10Z

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.316 ms 30.359 ms 30.403 ms]
change: [-3.7842% -3.0663% -2.6128%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

[dorimedini-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

---

crates/starknet_os/src/hints/error.rs line 50 at r3 (raw file):

    MemoryError(#[from] MemoryError),
    #[error("Convert {n_bits} bits for {type_name}.")]
    StatelessCompressionOverflow { n_bits: usize, type_name: String },

these are not alphabetized... while you're here can you fix it?

Code quote:

    #[error("Unknown hint string: {0}")]
    UnknownHint(String),
    #[error("The identifier {0:?} has no full name.")]
    IdentifierHasNoFullName(Box<Identifier>),
    #[error("The identifier {0:?} has no members.")]
    IdentifierHasNoMembers(Box<Identifier>),
    #[error(transparent)]
    MathError(#[from] MathError),
    #[error(transparent)]
    MemoryError(#[from] MemoryError),
    #[error("Convert {n_bits} bits for {type_name}.")]
    StatelessCompressionOverflow { n_bits: usize, type_name: String },

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 301 at r3 (raw file):

        get_integer_from_var_name(Ids::OldBlockHash.into(), vm, ids_data, ap_tracking)?;

    log::debug!("writing block number: {} -> block hash: {}", old_block_number, old_block_hash);

this is not in the original hint, right? why do you log it?

Code quote:

log::debug!("writing block number: {} -> block hash: {}", old_block_number, old_block_hash);

[aner-starkware]

crates/starknet_os/src/hints/hint_implementation/execution.rs line 301 at r3 (raw file):

Previously, dorimedini-starkware wrote…

this is not in the original hint, right? why do you log it?

It's in the Moonsong hint, though.

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware and @nimrod-starkware)

---

crates/starknet_os/src/hints/hint_implementation/execution.rs line 301 at r3 (raw file):

Previously, aner-starkware wrote…

It's in the Moonsong hint, though.

ok, not strictly necessary but nice to have

[aner-starkware]

crates/starknet_os/src/hints/error.rs line 50 at r3 (raw file):

Previously, dorimedini-starkware wrote…

these are not alphabetized... while you're here can you fix it?

https://reviewable.io/reviews/starkware-libs/sequencer/4651

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[dorimedini-starkware]

Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[dorimedini-starkware]

Reviewed 4 of 4 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)