chore(papyrus_base_layer): allow PriceSample to be serialized/deserialized #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Feb 19, 2025
This was referenced Feb 19, 2025
guy-starkware
force-pushed
the
guyn/l1price/node_config
branch
from
3613d16 to
4fa92a5
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
2 times, most recently
from
0a6c949 to
f7f56c4
Compare
asmaastarkware
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/papyrus_base_layer/src/lib.rs line 78 at r1 (raw file):
/// A struct that holds together the data on the base layer's gas prices, for a given timestamp. #[derive(Clone, Debug, Serialize, Deserialize)]
out of context in this PR
guy-starkware
changed the base branch from
guyn/l1price/node_config
to
graphite-base/4267
guy-starkware
commented
Feb 24, 2025
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)
crates/papyrus_base_layer/src/lib.rs line 78 at r1 (raw file):
Previously, asmaastarkware (asmaa-starkware) wrote…
out of context in this PR
What do you mean? I need this so I can send PriceSample as message between the scraper and provider components.
guy-starkware
force-pushed
the
graphite-base/4267
branch
from
45242ce to
7cbb83a
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
f7f56c4 to
f2631cb
Compare
guy-starkware
changed the base branch from
graphite-base/4267
to
guyn/l1price/node_config
guy-starkware
force-pushed
the
guyn/l1price/node_config
branch
from
7cbb83a to
dae725e
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
f2631cb to
201ae8e
Compare
guy-starkware
force-pushed
the
guyn/l1price/node_config
branch
from
dae725e to
6e5892c
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
201ae8e to
36f957f
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
36f957f to
a55efd3
Compare
guy-starkware
force-pushed
the
guyn/l1price/node_config
branch
from
6e5892c to
dc7c496
Compare
guy-starkware
changed the base branch from
guyn/l1price/node_config
to
graphite-base/4267
guy-starkware
force-pushed
the
graphite-base/4267
branch
from
dc7c496 to
5bfab04
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
a55efd3 to
023d5f2
Compare
guy-starkware
changed the base branch from
graphite-base/4267
to
guyn/l1price/node_config
guy-starkware
force-pushed
the
guyn/l1price/node_config
branch
from
5bfab04 to
5e12bae
Compare
guy-starkware
force-pushed
the
guyn/l1price/make_price_sample_serializable
branch
from
023d5f2 to
18b3953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.