feat(ci): compile bench targets #4230
Conversation
|
This change is |
alonh5
force-pushed
the
02-18-feat_ci_compile_bench_targets
branch
from
12ae3b6 to
43c6a96
Compare
alonh5
requested review from
adi-yakovian-starkware,
dorimedini-starkware and
Itay-Tsabary-Starkware
There was a problem hiding this comment.
Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @Itay-Tsabary-Starkware)
crates/starknet_committer_and_os_cli/benches/main.rs line 9 at r1 (raw file):
// update it in the mentioned file. Then upload the new files to GCS with this new prefix (run e.g., // gcloud storage cp LOCAL_FILE gs://committer-testing-artifacts/NEW_PREFIX/tree_flow_inputs.json).
Just out of curiosity: why aren't there run instructions in this file?
alonh5
force-pushed
the
02-18-feat_ci_compile_bench_targets
branch
from
43c6a96 to
e91233c
Compare
There was a problem hiding this comment.
Reviewable status: 5 of 8 files reviewed, 1 unresolved discussion (waiting on @adi-yakovian-starkware, @dorimedini-starkware, and @Itay-Tsabary-Starkware)
crates/starknet_committer_and_os_cli/benches/main.rs line 9 at r1 (raw file):
Previously, adi-yakovian-starkware (Adi Yakovian) wrote…
Just out of curiosity: why aren't there run instructions in this file?
I don't know, but I think this is run in the CI.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Itay-Tsabary-Starkware)
alonh5
force-pushed
the
02-18-feat_ci_compile_bench_targets
branch
from
e91233c to
8279fa6
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
alonh5
force-pushed
the
02-18-feat_ci_compile_bench_targets
branch
from
8279fa6 to
ae592f0
Compare
|
Benchmark movements: |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:
alonh5
force-pushed
the
02-18-feat_ci_compile_bench_targets
branch
from
ae592f0 to
f9a378b
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.