feat(consensus): send BlockInfo from proposer

[asmaastarkware]

Ayelet is working on removing NonzerGasPrice, a lot of things gonna change..
so these changes are temporary.

[reviewable-StarkWare]

This change is 

[asmaastarkware]

• feat(consensus): validate BlockInfo #3979
• feat(consensus): send BlockInfo from proposer #3908 👈 (View in Graphite)
• feat(papyrus_protobuf): add BlockInfo to ProposalPart #3884 : 1 other dependent PR (#3907 )
• feat(papyrus_protobuf): add BlockInfo to proto #3878
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 403 at r1 (raw file):

        self.cende_ambassador
            .prepare_blob_for_next_height(BlobParameters {
                // TODO(dvir): use the real `BlockInfo` when consensus will save it.

Maybe we can remove this TODO?

[asmaastarkware]

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @guy-starkware and @matan-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 403 at r1 (raw file):

Previously, guy-starkware wrote…

Maybe we can remove this TODO?

@matan-starkware WDYT about storing last_block_info when building/validating the block?

[matan-starkware]

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @asmaastarkware and @guy-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 403 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

@matan-starkware WDYT about storing last_block_info when building/validating the block?

Good catch, do this in another PR

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 596 at r2 (raw file):

        timestamp: now.timestamp().try_into().expect("Failed to convert timestamp"),
        builder: proposal_init.proposer,
        l1_da_mode: L1DataAvailabilityMode::Blob,

Confirming you plan to make this part of the config

Code quote:

        l1_da_mode: L1DataAvailabilityMode::Blob,

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 610 at r2 (raw file):

            hash: BlockHash::default(),
        }),
        // TODO(Dan, Matan): Fill block info.

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 847 at r2 (raw file):

        Some(ProposalPart::BlockInfo(_)) => {
            // TODO(Asmaa): Validate the block info.
            HandledProposalPart::Continue

We should make sure to receive this before we enter this loop. Inside of handle part this is like receiving Init (invalid proposal)

Code quote:

            // TODO(Asmaa): Validate the block info.
            HandledProposalPart::Continue

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 874 at r2 (raw file):

        }
        // TODO(Asmaa): Handle invalid proposal part by aborting the proposal, not the node.
        _ => panic!("Invalid proposal part: {:?}", proposal_part),

Suggestion:

 HandledProposalPart::Failed

[asmaastarkware]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @guy-starkware and @matan-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 403 at r1 (raw file):

Previously, matan-starkware wrote…

Good catch, do this in another PR

👍

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 596 at r2 (raw file):

Previously, matan-starkware wrote…

Confirming you plan to make this part of the config

next PR

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 847 at r2 (raw file):

Previously, matan-starkware wrote…

We should make sure to receive this before we enter this loop. Inside of handle part this is like receiving Init (invalid proposal)

yes, handled correctly next PR

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 610 at r2 (raw file):

            hash: BlockHash::default(),
        }),
        // TODO(Dan, Matan): Fill block info.

Done.

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 874 at r2 (raw file):

        }
        // TODO(Asmaa): Handle invalid proposal part by aborting the proposal, not the node.
        _ => panic!("Invalid proposal part: {:?}", proposal_part),

Done.

[github-actions]

Artifacts upload workflows:

• Started at 2025-02-05T14:10:33Z
• Started at 2025-02-06T08:07:33Z

[matan-starkware]

Reviewed 8 of 8 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @asmaastarkware and @guy-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 610 at r2 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

Done.

I don't see any change

[asmaastarkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware and @matan-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 610 at r2 (raw file):

Previously, matan-starkware wrote…

I don't see any change

Done.

[matan-starkware]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

[guy-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)

[guy-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)