Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockifier): remove redundent comment of fn test_stack_overflow that was modved #3886

Conversation

avivg-starkware
Copy link
Contributor

test_stack_overflow that was modved

test_stack_overflow that was modved
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Feb 2, 2025

Artifacts upload workflows:

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware marked this pull request as ready for review February 2, 2025 16:18
Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/blockifier/src/execution/syscalls/syscall_tests/out_of_gas.rs line 62 at r1 (raw file):

// TODO (AvivG) move this test to Transaction executor

this test was moved in a prev PR and not deleted #3515

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Contributor Author

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@avivg-starkware avivg-starkware merged commit 6f2e50a into main-v0.13.4 Feb 3, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants