-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blockifier): rename execution_tast_output feild 'writes' to state_diff' #3871
chore(blockifier): rename execution_tast_output feild 'writes' to state_diff' #3871
Conversation
Artifacts upload workflows: |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
69a927b
to
b445c22
Compare
21089c7
to
936c0cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
crates/blockifier/src/concurrency/worker_logic.rs
line 146 at r1 (raw file):
reads: transactional_state.cache.take().initial_reads, // Failed transaction - ignore the writes. state_diff: StateMaps::default(),
@Yoni-Starkware, I wasn't surre whether to edit the wording in the comment or not (to use 'state_diff' vs 'writes').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @avivg-starkware)
crates/blockifier/src/concurrency/worker_logic_test.rs
line 355 at r1 (raw file):
// writes and reads to and from the sequencer balance (to avoid the inevitable dependency // between all the transactions). let state_diff = StateMaps {
This is the set of writes, there might be tirival updates here.
Suggestion:
et writes
936c0cd
to
6012bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware)
crates/blockifier/src/concurrency/worker_logic_test.rs
line 355 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
This is the set of writes, there might be tirival updates here.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
b445c22
to
c267de1
Compare
6012bb1
to
7a7c52f
Compare
state_diff'