Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Notational conventions topic #1242

Merged
merged 8 commits into from
May 6, 2024
Merged

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented May 1, 2024

Description of the Changes

This PR adds a page describing notational conventions in the docs.

PR Preview URL

Notational conventions

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie requested a review from LandauRaz May 1, 2024 13:10
Copy link

github-actions bot commented May 1, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

Copy link

github-actions bot commented May 1, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

1 similar comment
Copy link

github-actions bot commented May 1, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie force-pushed the notational_conventions branch from 1eb92cc to 35bad58 Compare May 1, 2024 14:05
Copy link

github-actions bot commented May 1, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

1 similar comment
Copy link

github-actions bot commented May 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie force-pushed the notational_conventions branch from a8d9a8f to 1c19a49 Compare May 2, 2024 07:57
Copy link

github-actions bot commented May 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie changed the title docs: Add notational-conventions.adoc docs: Add Notational conventions topic May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie force-pushed the notational_conventions branch from 1c94293 to faf9b01 Compare May 2, 2024 10:17
Copy link

github-actions bot commented May 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

1 similar comment
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie requested review from ArielElp and removed request for LandauRaz May 5, 2024 12:25
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@LandauRaz
Copy link
Collaborator

Sorry for the delay, LGTM.

@stoobie stoobie requested a review from LandauRaz May 5, 2024 14:59
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1242/documentation/ .

@stoobie stoobie merged commit 7e0818d into main May 6, 2024
1 check passed
@stoobie stoobie deleted the notational_conventions branch May 6, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants