Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates to transaction_commitment in Block structure. #1211

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Apr 2, 2024

Description of the Changes

Fix description of transaction_commitment in Block structure.

PR Preview URL

Block structure

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Copy link

github-actions bot commented Apr 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1211/documentation/ .

@stoobie stoobie requested a review from ArielElp April 2, 2024 11:40
Copy link

github-actions bot commented Apr 2, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1211/documentation/ .

Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@stoobie stoobie merged commit 6bb0e9a into main Apr 2, 2024
3 of 4 checks passed
@stoobie stoobie deleted the steve/fix/transaction_commitment branch April 2, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants