Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add new topic on migrating from DAI v0 to DAI. #1181

Merged
merged 4 commits into from
Mar 17, 2024
Merged

docs: Add new topic on migrating from DAI v0 to DAI. #1181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf7ca36
Add new topic on migrating from DAI v0 to DAI.
stoobie Mar 14, 2024
d13318d
SME comments + meta info
stoobie Mar 14, 2024
6cc78d0
Playing with title
stoobie Mar 17, 2024
af69be7
Added Ekubo and Layerswap as sample swap apps
stoobie Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/Starknet/modules/tools/nav.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
**** xref:starkgate-adding_a_token.adoc[Adding a token]
**** xref:starkgate-cancelling a deposit.adoc[Cancelling a deposit]
**** xref:starkgate-estimating_fees.adoc[Estimating StarkGate fees]
**** xref:dai_token_migration.adoc[Migrating DAI tokens on Starknet to the new DAI contract]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets change the title to:
DAI Migration

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Although I'm not thrilled. This topic the way it was originally written is more of an announcement. If we're adding it to technical documentation, telling people how to migrated, it should really be a procedural heading like other procedural headings that end with "ing".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the title - I found the one you suggested a bit clumsy. Can you think of a compromise?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Migrating DAI v0 to DAI" for the topic title, and I'll change the procedure heading to "Procedure", like other Procedures?

*** xref:starkgate_function_reference.adoc[StarkGate function and event reference]

* Important addresses
Expand Down
32 changes: 32 additions & 0 deletions components/Starknet/modules/tools/pages/dai_token_migration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
[id="dai_token_migration"]
= Migrating DAI tokens on Starknet to the new DAI contract

Following link:https://twitter.com/MakerDAO/status/1746977683190251591?s=20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the preview, the link was not working, it was just there as text

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

[Maker DAO’s announcement on Jan 25th], StarkWare launched a new DAI contract and bridge on Starknet.

The new DAI token and bridge are a part of StarkGate and compatible with StarkGate 2.0 features.

You can withdraw old DAI tokens (DAI v0) without any limitation. Depositing using the DAI v0 bridge are disabled. You are encouraged to migrate to the new DAI token. You can use swap services on Starknet to swap DAI v0 for DAI.

You are encouraged to migrate your old DAI (DAI v0) tokens for new DAI tokens.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be deleted, it is repeated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Maker DAO's DAI token on Starknet is written in Cairo0 and is not upgradeable. Without upgradability, it cannot support StarkGate's latest features, such as Smart Deposits and Withdrawal Limits, and over time it will stop being compatible with Starknet altogether (Regenesis). This means that a transition plan is necessary.

On January 25th, StarkWare launched a new set of DAI bridge and token contracts under StarkGate, written in Cairo. This new DAI token will retain the same contract ’symbol’ and ’name’ as the existing one. To differentiate between the two on Apps and other UIs, we refer to the old DAI as “DAI v0” and the new DAI simply as “DAI.”


== Migrate from v0 Starknet DAI tokens to new Starknet DAI tokens
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer:
Migrate DAI v0 to DAI or Migrate your DAI v0
I don't like to refer to the new DAI as such. It is just DAI. Also, it is not Starknet DAI. It is just DAI. We chose names, I want to use them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I think it would be better to be as specific as possible. The naming you chose might be appropriate for conversations and targeted communications, but this page will show up in search results, and it'll probably generate false positives if we don't specify that it's referring to Starknet. I'll add more details in the :description: metadata.


Use one of the following methods:

* Use StarkGate:
+
. Withdraw your current DAI (DAI v0) to L1 using StarkGate
. Re-deposit your L1 DAI using StarkGate.
+
StarkGate automatically issues the new DAI.

* Swap your DAI v0 for DAI using an L2 swap app or aggregator within the Starknet ecosystem.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natan-granit Are there any more details than this? Is there an existing swap app or aggregator that we can point to? Or a page that lists all of them?

Copy link
Collaborator

@natan-granit natan-granit Mar 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are at least 2 I know of - should we add and be responsible for changing in the future?
LayerSwap - https://www.layerswap.io/migration/DAI
Ekubo - https://app.ekubo.org/?amount=1000&inputCurrency=DAI&outputCurrency=DAIv2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to give some guidance. Are there, or do you think there will be, more than these two?

Do you anticipate that these two will change?

Is there a search term that we can suggest to locate apps like this?




Loading