-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Minor edits to Setting up an account #1070
Conversation
components/Starknet/modules/quick_start/pages/set_up_an_account.adoc
Outdated
Show resolved
Hide resolved
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ . |
1 similar comment
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ . |
LGTM 👍 |
|
||
Ensure that the following commands show the version information for Starkli and Scarb: | ||
|
||
* Starkli and Scarb are installed correctly. Ensure that the following commands show the version information for Starkli and Scarb: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for Scarb if all you need is to deploy and account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amanusk OK. I removed Scarb. PTAL now.
components/Starknet/modules/quick_start/pages/set_up_an_account.adoc
Outdated
Show resolved
Hide resolved
components/Starknet/modules/quick_start/pages/set_up_an_account.adoc
Outdated
Show resolved
Hide resolved
components/Starknet/modules/quick_start/pages/set_up_an_account.adoc
Outdated
Show resolved
Hide resolved
Remove mention of Scarb from this topic.
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ . |
components/Starknet/modules/quick_start/pages/set_up_an_account.adoc
Outdated
Show resolved
Hide resolved
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ . |
1 similar comment
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ . |
Description of the Changes
Minor edits to Setting up an account
PR Preview URL
After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.
Paste here the specific URL(s) of the content that this PR addresses.
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is