Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Minor edits to Setting up an account #1070

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Jan 7, 2024

Description of the Changes

Minor edits to Setting up an account

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie requested a review from ArielElp January 7, 2024 08:54
Copy link

github-actions bot commented Jan 7, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ .

1 similar comment
Copy link

github-actions bot commented Jan 7, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ .

xiaolou86
xiaolou86 previously approved these changes Jan 8, 2024
@xiaolou86
Copy link
Contributor

xiaolou86 commented Jan 8, 2024

LGTM 👍


Ensure that the following commands show the version information for Starkli and Scarb:

* Starkli and Scarb are installed correctly. Ensure that the following commands show the version information for Starkli and Scarb:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need for Scarb if all you need is to deploy and account.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanusk OK. I removed Scarb. PTAL now.

Remove mention of Scarb from this topic.
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ .

Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ .

1 similar comment
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1070/documentation/ .

@stoobie stoobie merged commit d4a0f92 into main Jan 18, 2024
3 checks passed
@stoobie stoobie deleted the steve/set_up_an_account branch January 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants