Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added callouts to example in Data availability topic. #1006

Merged
merged 4 commits into from
Feb 29, 2024
Merged

feat: Added callouts to example in Data availability topic. #1006

merged 4 commits into from
Feb 29, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Dec 6, 2023 •
edited
Loading

Description of the Changes

Working on improving callout format.

PR Preview URL

v0.11.0 example of onchain data

Check List

  • Changes have been done against master branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1006/documentation/ .

@stoobie stoobie changed the base branch from master-to_be_deleted to main December 31, 2023 08:59
@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1006/documentation/ .

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1006/documentation/ .

@stoobie
Copy link
Collaborator Author

stoobie commented Feb 28, 2024

@drgnchan Would you please take a look at the Data Availability topic in this preview and let me know if you still see the bug you mentioned in #1144?

@drgnchan
Copy link

@drgnchan Would you please take a look at the Data Availability topic in this preview and let me know if you still see the bug you mentioned in #1144?

Sure. I have read at the Data Availability topic in this preview and the page looks well.

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1006/documentation/ .

@github-actions GitHub Actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1006/documentation/ .

@stoobie
Copy link
Collaborator Author

stoobie commented Feb 29, 2024

PR#32 in starknet-docs-antora-ui fixes this:

Update highlight.js and highlightjs-cairo plugin.

@stoobie stoobie merged commit e1b8500 into main Feb 29, 2024
3 checks passed
@stoobie stoobie deleted the steve/callouts branch February 29, 2024 10:08
xiaolou86 pushed a commit to xiaolou86/starknet-docs that referenced this pull request Apr 7, 2024
@stoobie @xiaolou86
feat: Added callouts to example in Data availability topic. (starknet…
70d7b16 
…-io#1006)

* Added callouts to example in Data availability topic.

* Update ui_bundle.zip to the one used in starknet-io/starknet-docs-antora-ui#33

* Revert ui_bundle.zip to the one used in HEAD.

* Using callouts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoobie @drgnchan