Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pytrec_eval to its own optional dependencies section #3470

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

yifanmai
Copy link
Collaborator

GitHub Actions can't install pytrec_eval for some reason, so we remove it.

Run uv pip compile setup.cfg --extra all --extra dev --universal --no-annotate --constraints constraints.txt -o requirements.txt
  × Failed to build `pytrec-eval==0.5`
  ├─▶ The build backend returned an error
  ╰─▶ Call to `setuptools.build_meta:__legacy__.build_wheel` failed (exit
      status: 1)

      [stdout]
      Fetching trec_eval from
      https://github.com/usnistgov/trec_eval/archive/v9.0.8.tar.gz.

      [stderr]
      Traceback (most recent call last):
        File "<string>", line 14, in <module>
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/build_meta.py",
      line 334, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/build_meta.py",
      line 304, in _get_build_requires
          self.run_setup()
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/build_meta.py",
      line 522, in run_setup
          super().run_setup(setup_script=setup_script)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/build_meta.py",
      line 320, in run_setup
          exec(code, locals())
        File "<string>", line 64, in <module>
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/__init__.py",
      line [11](https://github.com/stanford-crfm/helm/actions/runs/14039388122/job/39308699291#step:5:12)6, in setup
          _install_setup_requires(attrs)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/__init__.py",
      line 87, in _install_setup_requires
          dist.parse_config_files(ignore_option_errors=True)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/_virtualenv.py",
      line [20](https://github.com/stanford-crfm/helm/actions/runs/14039388122/job/39308699291#step:5:21), in parse_config_files
          result = old_parse_config_files(self, *args, **kwargs)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/dist.py",
      line 730, in parse_config_files
          self._parse_config_files(filenames=inifiles)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/dist.py",
      line 599, in _parse_config_files
          opt = self._enforce_underscore(opt, section)
        File
      "/home/runner/.cache/uv/builds-v0/.tmpnEgVyF/lib/python3.9/site-packages/setuptools/dist.py",
      line 6[29](https://github.com/stanford-crfm/helm/actions/runs/14039388122/job/39308699291#step:5:30), in _enforce_underscore
          raise InvalidConfigError(
      setuptools.errors.InvalidConfigError: Invalid dash-separated key
      'description-file' in 'metadata' (setup.cfg), please use the underscore
      name 'description_file' instead.

      hint: This usually indicates a problem with the package or the build
      environment.

@yifanmai yifanmai merged commit 4ec117f into main Mar 24, 2025
8 checks passed
@yifanmai yifanmai deleted the yifanmai/remove-pytrec branch March 24, 2025 19:14
@yifanmai
Copy link
Collaborator Author

Turns out this was caused by an upstream bug in setuptools pypa/setuptools#4910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant