fix issue: createItem not serializing Nothings correctly #81
+44
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields were reported in the issue as appearing with their values as null, when in fact they shouldn'd have appeared at all in the JSON serialization.
I've included them inside catMaybes so this is corrected. I've also created a couple of tests to determine whether a couple of fields (one of them with Nothing, the other one with a Just value) appear in the JSON serialization. Lastly, I've included a another dependency for the purposes of converting among Text, String, Bytestring and lazy Bytestring mostly for the new tests.