Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes workflow-ui/compose/README.md informative. #755

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented May 4, 2022

README.md is now the permanent home of the blog post that described in depth how this stuff would work, so that we can keep it up to date.

Closes #458

@rjrjr rjrjr requested review from a team as code owners May 4, 2022 16:59
@rjrjr rjrjr force-pushed the ray/compose-design branch from 9df5543 to 067fa6d Compare May 4, 2022 17:00
@rjrjr
Copy link
Contributor Author

rjrjr commented May 4, 2022

Cool, the markdown lint was actually useful!

@rjrjr rjrjr requested a review from zach-klippenstein as a code owner May 4, 2022 21:16
@rjrjr
Copy link
Contributor Author

rjrjr commented May 4, 2022

Useful is strong. Really, that linter is left over from https://github.com/square/workflow, where it's mainly about the docs/ directory. A smart person would have just deleted it, but instead I fixed all the line-to-long errors.

Need to take a pass to update the terminology and make it reflect what did and didn't get implemented, but there are more important holes to fill first. Tracking that at #787.

@rjrjr
Copy link
Contributor Author

rjrjr commented May 4, 2022

Okay, this is stupid. I'm going to delete the second SHA and just turn off the line length check.

`README.md` is now the permanent home of the [blog post](https://developer.squareup.com/blog/jetpack-compose-support-in-workflow/) that described in depth how this stuff would work, so that we can keep it up to date.

Closes #458
@rjrjr rjrjr force-pushed the ray/compose-design branch from 98a8460 to 0307732 Compare May 4, 2022 22:04
@rjrjr rjrjr merged commit ffba686 into main May 4, 2022
@rjrjr rjrjr deleted the ray/compose-design branch May 4, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Overall design for officially supporting Compose from Workflow
3 participants