[swift] Fix conformance to ProtoMessage for heap allocated protos #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
commented
Jan 23, 2025
| @@ -1911,6 +1911,14 @@ extension AllTypes : Proto2Codable { | |||
|
|
|||
| } | |||
|
|
|||
| extension AllTypes : ProtoMessage { | |||
There was a problem hiding this comment.
This was incorrectly missing.
lickel
approved these changes
Jan 23, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Feb 17, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | patch | `11.3.1` -> `11.3.2` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `5.2.1` -> `5.3.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.20` -> `2.30.21` | --- ### Release Notes <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.0`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-530) [Compare Source](square/wire@5.2.1...5.3.0) *2025-02-14* ##### Common - Add support for weak imports in ProtoParser and ProtoFileElement ([#​3247](square/wire#3247) by \[paul35621]\[paul35621]) - Add Gradle and CLI options to load the protobuf schema exhaustively ([#​3254](square/wire#3254) by \[Damian Wieczorek]\[damianw]) ##### Swift - Fix conformance to ProtoMessage for heap allocated protos ([#​3260](square/wire#3260) by \[Dimitris Koutsogiorgas]\[dnkoutso]) ##### Gradle plugin - Removed usage of internal Gradle APIs in the Wire Gradle plugin which were crashing in Gradle `8.13`. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 99093fc154f455e28ebe8007a19636cb549f15d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.