Fix histogram when there are larger differences in document count #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The large difference would cause histogram boxes not to be rendered when the counts were very different, very likely due to rounding issues. A similar fix was already in place when `aggregation_terms` was used, but not for regular queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The large difference would cause histogram boxes not to be rendered when the counts were very different, very likely due to rounding issues.
A similar fix was already in place when
aggregation_termswas used, but not for regular queries.Before:
After (note the tiny boxes after the big spike):
And for completeness, with
&aggregation_terms=level(same as before):