Add buckets for values without the aggregated field #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. when aggregating on `status.code` not all logs may have that field. Before they would not be represented in the histogram and result in misleading graphs, now they are shown as grey boxes on top of the ones that are aggregated on. This happened a couple times internally and should help point out weird values and prevent confusion when expected or assumed fields are missing.
heyLu
force-pushed
the
add-non-aggregated-buckets
branch
from
acecb4d to
16d325b
Compare
ivangonzalezacuna
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. when aggregating on
status.codenot all logs may have that field. Before they would not be represented in the histogram and result in misleading graphs, now they are shown as grey boxes on top of the ones that are aggregated on.This happened a couple times internally and should help point out weird values and prevent confusion when expected or assumed fields are missing.
Two example screenshots from internal usage:
Previously those grey boxes would simply not exist and the histograms would look complete (but aren't). Non-aggregated histograms were already correct and the bars now match in both, e.g. here for the first screenshot but without the aggregation: