SPL2 notebooks download/use the latest SPL2 language server by default #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by default. Also scope machine-specific installation settings (e.g. local paths) to only be tracked per-machine as opposed to across all users' machines.
…k/download-latest-spl2
haariskhan902
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were hardcoding which version to use. Users can also opt-out of this automatic update and/or hardcode to a specific version of the SPL2 Language server if they like, new setting:
In order to make it clear to the user which version of the language server is being used (also helpful for debugging issues for customers) the language server version is now displayed along with the current language server status at the bottom of the SPL2 notebook window:
Functional test logs also confirm the latest version is discovered and used (2.0.402 at the time of this PR) by default:
This PR also addresses an issue some users noticed where their machine-specific installation settings (e.g. local paths to Java or the SPL2 language server) were propagating across their devices. Changing these settings to
scope=machineshould correctly fix those settings to a given device where VSCode is installed.