SYN-4026: Add optional port field to http tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-tools
added a commit
to splunk/cla-agreement
that referenced
this pull request
May 10, 2024
|
I have read the Code of Conduct and I hereby accept the Terms |
greatestusername-splunk
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thank you so much for this add @sangn-splunk Really appreciate your contribution here! Great eyes on that test!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SYN-4026
Before the change?
The request and response body for http tests did not support a port field.
After the change?
Adds optional port field to request and response for http tests. I also noticed that
createHttpCheckV2Bodywas actually a body for a browser test, so I changed it to reflect an http test.Pull request checklist
make testacc), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Does this introduce a breaking change?