Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error module #22

Merged
merged 7 commits into from
Aug 3, 2024
Merged

Add error module #22

merged 7 commits into from
Aug 3, 2024

Conversation

dharanad
Copy link
Collaborator

@dharanad dharanad commented Aug 2, 2024

Closes #14

@dharanad
Copy link
Collaborator Author

dharanad commented Aug 2, 2024

I personally think, the naming & error message can be improved a lot. @vaibhawvipul But what do you think about the direction we are heading with this PR.

@vaibhawvipul
Copy link
Contributor

I personally think, the naming & error message can be improved a lot. @vaibhawvipul But what do you think about the direction we are heading with this PR.

Looking good to me so far.

@dharanad dharanad marked this pull request as ready for review August 3, 2024 08:21
@vaibhawvipul vaibhawvipul merged commit 742b052 into spacewalkhq:main Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error module
2 participants