Switch to using chrony instead of ntpd #3574

saiarcot895 · 2024-10-14T05:45:23Z

What I did

Switch to calling chronyc instead of ntpq and ntpstat. This is as part of switching to using Chrony instead of ntpd.

Buildimage PR: sonic-net/sonic-buildimage#20497

How I did it

Replace calls to ntpq, ntpstat with chrony, as the former commands will no longer work.
Restart the chrony service instead of the ntp-config service (which also handles regeneration of /etc/chrony/chrony.conf).
Add support for accepting the NTP version, iburst, and association type from the CLI. Previously, these could only be specified via writing to config_db directly.

How to verify it

Previous command output (if the output of a command-line utility has changed)

admin@strtk5-msn2700-02:~$ sudo config ntp add --help
Usage: config ntp add [OPTIONS] <ntp_ip_address>

  Add NTP server IP

Options:
  -h, -?, --help  Show this message and exit.

With ntpd, time synchronized:

admin@strtk5-msn2700-02:~$ show ntp
MGMT_VRF_CONFIG is not present.
synchronised to unspecified at stratum 3
   time correct to within 47 ms
   polling server every 64 s
     remote           refid      st t when poll reach   delay   offset   jitter
===============================================================================
*10.212.65.2     10.201.148.43    2 u   17   64  377   0.2070  -1.0223   0.1344

With ntpd, time not synchronized:

admin@vlab-05:~$ show ntp
MGMT_VRF_CONFIG is not present.
unsynchronised
   polling server every 1 s

New command output (if the output of a command-line utility has changed)

admin@vlab-01:~$ sudo config ntp add --help
Usage: config ntp add [OPTIONS] <ntp_ip_address>

  Add NTP server IP

Options:
  --association-type [server|pool]
                                  Define the association type for this NTP
                                  server
  --iburst                        Enable iburst for this NTP server
  --version INTEGER               Specify the version for this NTP server
  -?, -h, --help                  Show this message and exit.

With chrony, time not synchronized:

admin@vlab-01:~$ show ntp
MGMT_VRF_CONFIG is not present.
Reference ID    : 00000000 ()
Stratum         : 0
Ref time (UTC)  : Thu Jan 01 00:00:00 1970
System time     : 0.000000000 seconds fast of NTP time
Last offset     : +0.000000000 seconds
RMS offset      : 0.000000000 seconds
Frequency       : 0.000 ppm slow
Residual freq   : +0.000 ppm
Skew            : 0.000 ppm
Root delay      : 1.000000000 seconds
Root dispersion : 1.000000000 seconds
Update interval : 0.0 seconds
Leap status     : Not synchronised
MS Name/IP address         Stratum Poll Reach LastRx Last sample
===============================================================================
^? 10.11.0.1                     0   6     0     -     +0ns[   +0ns] +/-    0ns
^? 10.11.0.2                     0   6     0     -     +0ns[   +0ns] +/-    0ns

With chrony, time synchronized:

admin@vlab-01:~$ show ntp
MGMT_VRF_CONFIG is not present.
Reference ID    : 0AFA0001 (10.250.0.1)
Stratum         : 2
Ref time (UTC)  : Thu Mar 06 00:27:21 2025
System time     : 0.000000000 seconds fast of NTP time
Last offset     : -0.000010956 seconds
RMS offset      : 0.000010956 seconds
Frequency       : 5.709 ppm slow
Residual freq   : -0.000 ppm
Skew            : 13.460 ppm
Root delay      : 0.000119419 seconds
Root dispersion : 0.000720337 seconds
Update interval : 2.0 seconds
Leap status     : Normal
MS Name/IP address         Stratum Poll Reach LastRx Last sample
===============================================================================
^? 10.11.0.1                     0   7     0     -     +0ns[   +0ns] +/-    0ns
^? 10.11.0.2                     0   7     0     -     +0ns[   +0ns] +/-    0ns
^* 10.250.0.1                    1   6    17    46  -3332ns[  -14us] +/-  103us

When adding new NTP servers via the CLI, allow options such as iburst, version, and the association type to be specified. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-02T01:47:34Z

/azp run

azure-pipelines · 2025-01-02T01:47:44Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-12T22:24:46Z

/azp run

azure-pipelines · 2025-01-12T22:24:56Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 · 2025-01-28T17:26:27Z

/azpw run

mssonicbld · 2025-01-28T17:26:29Z

/AzurePipelines run

azure-pipelines · 2025-01-28T17:26:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Pool NTP servers are typically domain names, and will resolve to multiple IP addresses. All of those IP addresses are expected to be used. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-29T21:12:47Z

/azp run

azure-pipelines · 2025-01-29T21:12:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-29T23:30:08Z

/azp run

azure-pipelines · 2025-01-29T23:30:18Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-29T23:50:23Z

/azp run

azure-pipelines · 2025-01-29T23:50:33Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-29T23:53:09Z

/azp run

azure-pipelines · 2025-01-29T23:53:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-30T01:41:11Z

/azp run

azure-pipelines · 2025-01-30T01:41:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-01-30T22:53:59Z

/azp run

azure-pipelines · 2025-01-30T22:54:09Z

Azure Pipelines successfully started running 1 pipeline(s).

yxieca · 2025-03-05T01:53:04Z

@saiarcot895 can you fill the PR template?

mssonicbld · 2025-03-05T23:02:35Z

/azp run

azure-pipelines · 2025-03-05T23:02:42Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

saiarcot895 · 2025-03-05T23:04:01Z

/azpw run

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-03-05T23:14:18Z

/azp run

azure-pipelines · 2025-03-05T23:14:25Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

saiarcot895 · 2025-03-05T23:24:20Z

/azpw run

mssonicbld · 2025-03-05T23:24:23Z

/AzurePipelines run

azure-pipelines · 2025-03-05T23:24:33Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-03-06T00:34:08Z

/azp run

azure-pipelines · 2025-03-06T00:34:18Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

mssonicbld · 2025-03-06T01:32:03Z

/azp run

azure-pipelines · 2025-03-06T01:32:13Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-03-17T06:54:11Z

/azp run

azure-pipelines · 2025-03-17T06:54:22Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 force-pushed the switch-to-chrony branch from 5ae9cbe to f7bc08e Compare October 15, 2024 19:18

saiarcot895 added 3 commits October 29, 2024 11:54

Add options to configure new NTP servers

1914cef

When adding new NTP servers via the CLI, allow options such as iburst, version, and the association type to be specified. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Replace ntp-config and ntpd with chrony

8a2705d

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Merge commit '428d6da9f9' into switch-to-chrony

a7f2b5d

saiarcot895 force-pushed the switch-to-chrony branch from f7bc08e to a7f2b5d Compare January 2, 2025 01:47

Merge commit '3aec51927b' into switch-to-chrony

a76d008

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 added 2 commits January 29, 2025 13:11

If adding a pool NTP server, allow non-IP addresses

95144c7

Pool NTP servers are typically domain names, and will resolve to multiple IP addresses. All of those IP addresses are expected to be used. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Add tests

951e266

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fix tests

ab7bb4b

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fix tests and fix some formatting issues

4df1692

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fix remaining formatting errors

02a2e64

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Rework tests to initialize the DB with what should be present

2f772ef

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Fix syntax of specifying expected calls

c3057b5

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 added 2 commits January 30, 2025 12:04

Update show runningconfiguration ntp for chrony

ca85304

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Don't call hwclock, it'll no longer work with chrony

8d0fe4c

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 marked this pull request as ready for review March 3, 2025 23:48

saiarcot895 requested review from qiluo-msft, yxieca and vaibhavhd March 4, 2025 16:22

Merge commit '940ed0ddd6' into switch-to-chrony

46fc7b6

Fix sudo config ntp add no longer working

83d1938

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

yxieca previously approved these changes Mar 6, 2025

View reviewed changes

Fix test vs runtime check

ea5987c

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

saiarcot895 dismissed yxieca’s stale review via ea5987c March 6, 2025 00:34

I missed a not

706f7d2

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

Merge commit 'fd43d513e7' into switch-to-chrony

a740ecc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to using chrony instead of ntpd #3574

Switch to using chrony instead of ntpd #3574

saiarcot895 commented Oct 14, 2024 •

edited

Loading

mssonicbld commented Jan 2, 2025

azure-pipelines bot commented Jan 2, 2025

mssonicbld commented Jan 12, 2025

azure-pipelines bot commented Jan 12, 2025

saiarcot895 commented Jan 28, 2025

mssonicbld commented Jan 28, 2025

azure-pipelines bot commented Jan 28, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 30, 2025

azure-pipelines bot commented Jan 30, 2025

mssonicbld commented Jan 30, 2025

azure-pipelines bot commented Jan 30, 2025

yxieca commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

saiarcot895 commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

saiarcot895 commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

mssonicbld commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

mssonicbld commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

mssonicbld commented Mar 17, 2025

azure-pipelines bot commented Mar 17, 2025

Switch to using chrony instead of ntpd #3574

Are you sure you want to change the base?

Switch to using chrony instead of ntpd #3574

Conversation

saiarcot895 commented Oct 14, 2024 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

mssonicbld commented Jan 2, 2025

azure-pipelines bot commented Jan 2, 2025

mssonicbld commented Jan 12, 2025

azure-pipelines bot commented Jan 12, 2025

saiarcot895 commented Jan 28, 2025

mssonicbld commented Jan 28, 2025

azure-pipelines bot commented Jan 28, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 29, 2025

azure-pipelines bot commented Jan 29, 2025

mssonicbld commented Jan 30, 2025

azure-pipelines bot commented Jan 30, 2025

mssonicbld commented Jan 30, 2025

azure-pipelines bot commented Jan 30, 2025

yxieca commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

saiarcot895 commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

saiarcot895 commented Mar 5, 2025

mssonicbld commented Mar 5, 2025

azure-pipelines bot commented Mar 5, 2025

mssonicbld commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

mssonicbld commented Mar 6, 2025

azure-pipelines bot commented Mar 6, 2025

mssonicbld commented Mar 17, 2025

azure-pipelines bot commented Mar 17, 2025

saiarcot895 commented Oct 14, 2024 •

edited

Loading