modifying psushow script to use key names instead of index #3208

gregoryboudreau · 2024-03-11T18:05:14Z

What I did

Change psushow to use key names under the PSU_INFO|* banner for clarity instead of via indexing method as was done previously.

How I did it

As stated above, query for keys in a sorted manner and grab/display information like that instead of grabbing information based on PSU index

How to verify it

Run psushow command (or its SONiC mask show platform psustatus)

Previous command output (if the output of a command-line utility has changed)

cisco@sfd-t2-sup:~$ psushow --status
PSU    Model            Serial       HW Rev    Voltage (V)    Current (A)    Power (W)    Status       LED
-----  ---------------  -----------  --------  -------------  -------------  -----------  -----------  -----
PSU 1  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 2  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 3  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 4  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 5  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 6  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
PSU 7  PSU6.3KW-20A-HV  DTM243501TF  1.0       54.426         35.309         1924.904     OK           green
PSU 8  PSU6.3KW-20A-HV  DTM243501WZ  1.0       54.582         18.27          999.402      OK           green
PSU 9  PSU6.3KW-20A-HV  DTM243501TU  1.0       54.582         17.996         985.326      OK           green

New command output (if the output of a command-line utility has changed)

cisco@yy39-rp:~$ show plat psu
PSU            Model            Serial       HW Rev    Voltage (V)    Current (A)    Power (W)    Status       LED
-------------  ---------------  -----------  --------  -------------  -------------  -----------  -----------  -----
psutray0.psu0  PSU6.3KW-20A-HV  DTM2503026B  1.0       N/A            N/A            N/A          NOT OK       off
psutray0.psu1  N/A              N/A          N/A       N/A            N/A            N/A          NOT PRESENT  N/A
psutray0.psu2  PSU6.3KW-20A-HV  DTM255001J9  1.0       N/A            N/A            N/A          NOT OK       off
psutray1.psu0  PSU6.3KW-20A-HV  DTM255001JK  1.0       N/A            N/A            N/A          NOT OK       off
psutray1.psu1  PSU6.3KW-20A-HV  DTM253401KD  1.0       N/A            N/A            N/A          NOT OK       off
psutray1.psu2  PSU6.3KW-20A-HV  DTM253404FZ  1.0       54.348         18.407         1002.921     OK           green
psutray2.psu0  PSU6.3KW-20A-HV  DTM255001JF  1.0       54.504         18.202         995.883      OK           green
psutray2.psu1  PSU6.3KW-20A-HV  DTM255001HM  1.0       54.426         18.27          995.883      OK           green
psutray2.psu2  PSU6.3KW-20A-HV  DTM255001HU  1.0       54.582         18.681         1020.516     OK           green

Related PRs:
sonic-net/sonic-mgmt#11944
sonic-net/sonic-platform-daemons#446
sonic-net/sonic-snmpagent#312

prgeor · 2024-04-09T03:08:10Z

@gregoryboudreau from user perspective isn't the previous output easily readable compared to your proposal?

gregoryboudreau · 2024-04-09T04:10:01Z

@gregoryboudreau from user perspective isn't the previous output easily readable compared to your proposal?

It depends. Having enumerated names can make it "readable" but provides minimal information about the actual device. By using the vendor defined name (if available), we can provide more accurate and contextual information for the user in the same way we do for fans/fantrays. The enumerated names can also cause confusion as the PSU enumeration != PSU index and may != PSU name. It is better to organize these under a simple and vendor implemented manner, same as fan trays.

gechiang · 2024-06-03T21:28:16Z

/azp run

azure-pipelines · 2024-06-03T21:28:26Z

Azure Pipelines successfully started running 1 pipeline(s).

assrinivasan · 2024-06-03T22:36:59Z

@gregoryboudreau could you please add the corresponding unit test to: sonic-utilities/tests/psushow_test.py ? It is currently testing the old format.

prgeor · 2024-06-04T18:07:45Z

@gregoryboudreau could you please run test_psu*.py from sonic-mgmt test and attach the result to PR?

gregoryboudreau · 2024-09-13T00:07:34Z

will update test and attach logs for test_psu

mssonicbld · 2025-02-17T06:03:41Z

/azp run

azure-pipelines · 2025-02-17T06:03:51Z

Azure Pipelines successfully started running 1 pipeline(s).

gregoryboudreau · 2025-02-17T08:07:27Z

@gregoryboudreau could you please add the corresponding unit test to: sonic-utilities/tests/psushow_test.py ? It is currently testing the old format.

the existing test applies to both the old and new format, I guess I will have to make a follow up PR to add additional test cases for both this new and old logic as cases that are exclusive to the new logic will break without the other PRs already merged.

gregoryboudreau · 2025-02-18T04:15:09Z

@gregoryboudreau could you please run test_psu*.py from sonic-mgmt test and attach the result to PR?

platform_tests/api/test_psu.py::TestPsuApi::test_get_name[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                      [  2%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_presence[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                  [  4%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_model[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                     [  7%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_serial[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                    [  9%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_revision[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                  [ 11%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_status[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                    [ 14%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_position_in_parent[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                        [ 16%] 
platform_tests/api/test_psu.py::TestPsuApi::test_is_replaceable[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                [ 19%] 
platform_tests/api/test_psu.py::TestPsuApi::test_fans[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                          [ 21%] 
platform_tests/api/test_psu.py::TestPsuApi::test_power[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                         [ 23%] 
platform_tests/api/test_psu.py::TestPsuApi::test_temperature[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                   [ 26%] 
platform_tests/api/test_psu.py::TestPsuApi::test_led[sfd-lt2-lc0] SKIPPED (On Cisco 8000, mellanox and Nokia 7215 platform, PSU led are unable to be controlled by software)                                                                  [ 28%] 
platform_tests/api/test_psu.py::TestPsuApi::test_thermals[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                      [ 30%] 
platform_tests/api/test_psu.py::TestPsuApi::test_master_led[sfd-lt2-lc0] SKIPPED (No psus found on device)                                                                                                                                    [ 33%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_name[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                      [ 35%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_presence[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                  [ 38%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_model[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                     [ 40%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_serial[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                    [ 42%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_revision[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                  [ 45%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_status[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                    [ 47%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_position_in_parent[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                        [ 50%] 
platform_tests/api/test_psu.py::TestPsuApi::test_is_replaceable[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                [ 52%] 
platform_tests/api/test_psu.py::TestPsuApi::test_fans[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                          [ 54%] 
platform_tests/api/test_psu.py::TestPsuApi::test_power[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                         [ 57%] 
platform_tests/api/test_psu.py::TestPsuApi::test_temperature[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                   [ 59%] 
platform_tests/api/test_psu.py::TestPsuApi::test_led[sfd-lt2-lc2] SKIPPED (On Cisco 8000, mellanox and Nokia 7215 platform, PSU led are unable to be controlled by software)                                                                  [ 61%] 
platform_tests/api/test_psu.py::TestPsuApi::test_thermals[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                      [ 64%] 
platform_tests/api/test_psu.py::TestPsuApi::test_master_led[sfd-lt2-lc2] SKIPPED (No psus found on device)                                                                                                                                    [ 66%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_name[sfd-lt2-sup] PASSED                                                                                                                                                                 [ 69%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_presence[sfd-lt2-sup] PASSED                                                                                                                                                             [ 71%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_model[sfd-lt2-sup] PASSED                                                                                                                                                                [ 73%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_serial[sfd-lt2-sup] PASSED                                                                                                                                                               [ 76%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_revision[sfd-lt2-sup] PASSED                                                                                                                                                             [ 78%] 
platform_tests/api/test_psu.py::TestPsuApi::test_get_status[sfd-lt2-sup] PASSED                                                                                                                                                               [ 80%]
platform_tests/api/test_psu.py::TestPsuApi::test_get_position_in_parent[sfd-lt2-sup] PASSED                                                                                                                                                   [ 83%]
platform_tests/api/test_psu.py::TestPsuApi::test_is_replaceable[sfd-lt2-sup] PASSED                                                                                                                                                           [ 85%]
platform_tests/api/test_psu.py::TestPsuApi::test_fans[sfd-lt2-sup] PASSED                                                                                                                                                                     [ 88%]
platform_tests/api/test_psu.py::TestPsuApi::test_power[sfd-lt2-sup] PASSED                                                                                                                                                                    [ 90%]
platform_tests/api/test_psu.py::TestPsuApi::test_temperature[sfd-lt2-sup] PASSED                                                                                                                                                              [ 92%]
platform_tests/api/test_psu.py::TestPsuApi::test_led[sfd-lt2-sup] SKIPPED (On Cisco 8000, mellanox and Nokia 7215 platform, PSU led are unable to be controlled by software)                                                                  [ 95%]
platform_tests/api/test_psu.py::TestPsuApi::test_thermals[sfd-lt2-sup] PASSED                                                                                                                                                                 [ 97%]
platform_tests/api/test_psu.py::TestPsuApi::test_master_led[sfd-lt2-sup] PASSED                                                                                                                                                               [100%]

test_psu.py passes with this changeset applied (this was run on t2 distributed chassis)

bmridul · 2025-03-11T21:25:50Z

@prgeor Can u pls check this PR.

rlhui · 2025-03-12T17:39:57Z

@mlok-nokia

modifying psushow script to use key names instead of index

c382f9d

gechiang requested review from prgeor and assrinivasan June 3, 2024 21:27

gechiang approved these changes Jun 3, 2024

View reviewed changes

Merge branch 'sonic-net:master' into psu_key_changes

576fb49

rlhui requested a review from judyjoseph March 12, 2025 17:39

mlok-nokia approved these changes Mar 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modifying psushow script to use key names instead of index #3208

modifying psushow script to use key names instead of index #3208

gregoryboudreau commented Mar 11, 2024 •

edited

Loading

prgeor commented Apr 9, 2024

gregoryboudreau commented Apr 9, 2024

gechiang commented Jun 3, 2024

azure-pipelines bot commented Jun 3, 2024

assrinivasan commented Jun 3, 2024

prgeor commented Jun 4, 2024

gregoryboudreau commented Sep 13, 2024

mssonicbld commented Feb 17, 2025

azure-pipelines bot commented Feb 17, 2025

gregoryboudreau commented Feb 17, 2025

gregoryboudreau commented Feb 18, 2025

bmridul commented Mar 11, 2025

rlhui commented Mar 12, 2025

modifying psushow script to use key names instead of index #3208

Are you sure you want to change the base?

modifying psushow script to use key names instead of index #3208

Conversation

gregoryboudreau commented Mar 11, 2024 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

prgeor commented Apr 9, 2024

gregoryboudreau commented Apr 9, 2024

gechiang commented Jun 3, 2024

azure-pipelines bot commented Jun 3, 2024

assrinivasan commented Jun 3, 2024

prgeor commented Jun 4, 2024

gregoryboudreau commented Sep 13, 2024

mssonicbld commented Feb 17, 2025

azure-pipelines bot commented Feb 17, 2025

gregoryboudreau commented Feb 17, 2025

gregoryboudreau commented Feb 18, 2025

bmridul commented Mar 11, 2025

rlhui commented Mar 12, 2025

gregoryboudreau commented Mar 11, 2024 •

edited

Loading