Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vstest]: Fix MACsec test in the kernel 5.15 #3549

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

Pterosaur
Copy link
Contributor

What I did
Provide an explicit value for send_sci in the macsec vstest

Why I did it

The kernel 5.15 requires the send_sci to be true if the sci value was provided explicitly.

How I verified it

AzDevOps@test-os-u000048:/agent/_work/1/s/sonic-swss/tests$ sudo pytest --dvsname=vs test_macsec.py  --pdb
=========================================================================================== test session starts ============================================================================================
platform linux -- Python 3.8.10, pytest-4.6.2, py-1.11.0, pluggy-0.13.1
rootdir: /agent/_work/1/s/sonic-swss/tests
plugins: flaky-3.7.0
collected 4 items                                                                                                                                                                                          

test_macsec.py ....                                                                                                                                                                                  [100%]

============================================================================================= warnings summary =============================================================================================
test_macsec.py:311
  /agent/_work/1/s/sonic-swss/tests/test_macsec.py:311: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert(

test_macsec.py:278
  /agent/_work/1/s/sonic-swss/tests/test_macsec.py:278: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert(

test_macsec.py:251
  /agent/_work/1/s/sonic-swss/tests/test_macsec.py:251: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert(

test_macsec.py:258
  /agent/_work/1/s/sonic-swss/tests/test_macsec.py:258: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert(

test_macsec.py:264
  /agent/_work/1/s/sonic-swss/tests/test_macsec.py:264: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert(

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================================================== 4 passed, 5 warnings in 78.32 seconds ===================================================================================

Details if related

@Pterosaur Pterosaur requested a review from prsunny as a code owner March 7, 2025 13:30
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@xwjiang-ms
Copy link

The build didn't trigger, close/re-open the PR to trigger the build

@xwjiang-ms xwjiang-ms closed this Mar 9, 2025
@xwjiang-ms xwjiang-ms reopened this Mar 9, 2025
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 8447919 into sonic-net:master Mar 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants