[smartswitch] Add support for ENI Based Forwarding #3398
Conversation
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny kindly reminder to review it to avoid additional conflicts |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @prsunny, Any ETA to finish review on this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
orchagent/aclorch.cpp
Outdated
| @@ -619,6 +623,7 @@ bool AclTableRangeMatch::validateAclRuleMatch(const AclRule& rule) const | |||
| return true; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
please remove these extra lines (formatting changes)
orchagent/dash/dashenifwdorch.h
Outdated
|
|
||
| // TODO: Update in sonic-swss-common schema.h | ||
| #define CFG_DPU_TABLE "DPU_TABLE" | ||
| #define APP_DASH_ENI_FORWARD_TABLE "DASH_ENI_FORWARD_TABLE" |
There was a problem hiding this comment.
Can we move these to swss common since a later change may break the code.
There was a problem hiding this comment.
Removed, Will raise a swss-common PR
| return update_type; | ||
| } | ||
|
|
||
| void EniAclRule::fire(EniInfo& eni) |
There was a problem hiding this comment.
Please add a description of this function and what steps are executed.
| } | ||
| } | ||
|
|
||
| void DashEniFwdOrch::handleNeighUpdate(const NeighborUpdate& update) |
There was a problem hiding this comment.
Please add a description. Also is it only for new neighbor add or do you also handle delete neighbor?
There was a problem hiding this comment.
Updated, only neigh update is supported as of now
bool EniInfo::update(const NeighborUpdate& nbr_update)
{
if (nbr_update.add)
{
fireAllRules();
}
else
{
/*
Neighbor Delete handling not supported yet
When this update comes, ACL rule must be deleted first, followed by the NEIGH object
*/
}
return true;
}
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prsunny kindly reminder to approve it |
Hi Liat, we need to get swss-common to approve/merge before this PR |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @prsunny, Here is the dependent PR: sonic-net/sonic-swss-common#976 |
|
@vivekrnv , swss-common PR is merged. would you update this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did
HLD: sonic-net/SONiC#1842
Requires sonic-net/sonic-swss-common#976
Add DashEniFwdOrch which installs ACL rules to Redirect the DASH packet to corresponding DPU
Why I did it
How I verified it
Result:
Details if related