Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-swss] ARMHF warning fixes #1325

Merged
merged 1 commit into from
Jul 3, 2020
Merged

[sonic-swss] ARMHF warning fixes #1325

merged 1 commit into from
Jul 3, 2020

Conversation

antony-rheneus
Copy link
Contributor

Compiler Warnings : cast increases required alignment of target type [-Wcast-align]
Fix: Use reintrepret cast to cast lower size pointer to bigger size
pointer types

Signed-off-by: Antony Rheneus arheneus@marvell.com

What I did

Why I did it

How I verified it

Details if related

@antony-rheneus
[sonic-swss] ARMHF warning fixes
74a36f2 
Compiler Warnings : cast increases required alignment of target type [-Wcast-align]
Fix: Use reintrepret cast to cast lower size pointer to bigger size
pointer types

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@antony-rheneus antony-rheneus mentioned this pull request Jun 18, 2020
Closed
@lguohan lguohan requested a review from qiluo-msft June 22, 2020 06:04
qiluo-msft
qiluo-msft reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comment

@lguohan
Copy link
Contributor

lguohan commented Jun 23, 2020

Retest this please

1 similar comment
@lguohan
Copy link
Contributor

lguohan commented Jul 2, 2020

Retest this please

@antony-rheneus
Copy link
Contributor Author

Errors are seen at conftest.py.

18:14:33 fakeplatform = getattr(request.module, "DVS_FAKE_PLATFORM", None) 18:14:33 > dvs = DockerVirtualSwitch(name, imgname, keeptb, fakeplatform) 18:14:33 18:14:33 conftest.py:1014: 18:14:33 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 18:14:33 conftest.py:225: in __init__ 18:14:33 server = VirtualServer(self.ctn_sw.name, self.ctn_sw_pid, i) 18:14:33 conftest.py:112: in __init__ 18:14:33 ensure_system("ip link add %s type veth peer name %s" % (self.nsname[0:12], self.pifname)) 18:14:33 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 18:14:33 18:14:33 cmd = 'ip link add blissful_sin type veth peer name eth4' 18:14:33 18:14:33 def ensure_system(cmd): 18:14:33 (rc, output) = commands.getstatusoutput(cmd) 18:14:33 if rc: 18:14:33 > raise RuntimeError('Failed to run command: %s. rc=%d. output: %s' % (cmd, rc, output)) 18:14:33 E RuntimeError: Failed to run command: ip link add blissful_sin type veth peer name eth4. rc=512. output: RTNETLINK answers: File exists 18:14:33 18:14:33 conftest.py:26: RuntimeError 18:14:33 - generated xml file: /data/johnar/workspace/vs/sonic-swss-build-pr/swss/tests/tr.xml - 18:14:33 ===Flaky Test Report===

@antony-rheneus
Copy link
Contributor Author

Retest this please

@lguohan lguohan merged commit 2ebd44e into sonic-net:master Jul 3, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
[vrf]: Fix freezing during interface binding (sonic-net#1325)
a6ae218 
* Replacing using 'get_all' with 'exists' in port state checking procedure inside bind function to avoid freezing in the while loop, what caused by absence of related record in STATE_DB.

Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antony-rheneus @lguohan @qiluo-msft