LAG LACP & L3 Support #146
Conversation
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saivpp/src/SwitchStateBaseFdb.cpp
Outdated
| } | ||
|
|
||
| // Set mode and lb. SONiC config does not have provision to pass mode and load balancing algorithm | ||
| mode = VPP_BOND_API_MODE_XOR; | ||
| lb = VPP_BOND_API_LB_ALGO_L23; |
There was a problem hiding this comment.
for l3 port channel interface, LB algo should be L34. Can we change the algo when it is assigned?
There was a problem hiding this comment.
Do you mean when an IP is assigned? I couldn't find a way to dynamically modify the bond LB algorithm in VPP. It looks like it requires a bond delete/create or modifying the VPP API to allow for this operation. I can change the default to L34 for now given the sonic-mgmt use-case we are targeting. I had called this out in the LAG HLD as a potential Phase 2 work-item (along with t0-lag support).
There was a problem hiding this comment.
Yes, let's use L34 as default
There was a problem hiding this comment.
Done. Also successfully tested L2 traffic.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit f7783c7.
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Adding support for LAG LACP & L3. Addresses #140 and #90.
See the corresponding sections in the LAG HLD for details of the changes in this PR.