Add support to media settings parser for parsing gearbox media settings #579
+328
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Feb 7, 2025
| @@ -192,6 +259,33 @@ | |||
| } | |||
| } | |||
|
|
|||
| media_settings_gb_default = { | |||
There was a problem hiding this comment.
@j-mazurek is there any HLD describing these? Like how OA knows this SI setting corresponds to gearbox line side or not?
There was a problem hiding this comment.
prgeor
reviewed
Feb 15, 2025
| if xcvrd.check_port_in_range(port, physical_port): | ||
| media_dict = g_dict[GLOBAL_MEDIA_SETTINGS_KEY][keys] | ||
| if gearbox_side: | ||
| if GEARBOX_GLOBAL_MEDIA_SETTINGS_KEY in g_dict: |
There was a problem hiding this comment.
@j-mazurek can you write a separate function get_gb_media_settings() do the necessary refactor?
prgeor
reviewed
Feb 15, 2025
| @@ -208,9 +208,13 @@ def get_media_settings_for_speed(settings_dict, lane_speed_key): | |||
| return settings_dict.get(LANE_SPEED_DEFAULT_KEY, {}) | |||
|
|
|||
|
|
|||
| def get_media_settings_value(physical_port, key): | |||
| def get_media_settings_value(physical_port, key, gearbox_side=None): | |||
There was a problem hiding this comment.
@j-mazurek please rename this to get_asic_media_settings() and keep it separate from get_gb_media_settings()` (see my comments below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support to media_settings_parser in xcvrd to parse gearbox tuning values from media_settings.json.
Description
Added GEARBOX_GLOBAL_MEDIA_SETTINGS and GEARBOX_PORT_MEDIA_SETTINGS as top-level search keys for media_settings_parser.py in xcvrd.
Expanded get_media_settings() to parse gearbox values
Gearbox tuning values (line-side and system-side) parsed from media_settings.json will be published to APPL_DB alongside ASIC values.
Motivation and Context
This change is part of the Dynamic Gearbox Tuning feature. Allows parsing gearbox tuning values from media_settings.json.
How Has This Been Tested?
Using a custom media_settings.json file, verified that port tables in APPL_DB were being correctly set with the proper values for ASIC tx_taps as well as line-side and system-side gearbox tx_taps.
Verified against current unit tests.
Added unit test cases in test_xcvrd.py to cover new changes.