Add high power class support for non-CMIS modules in xcvrd #574
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if power_class < 5: | ||
| # No action needed for power class < 5 | ||
| return | ||
|
|
There was a problem hiding this comment.
@prgeor
Continue the discussion of sonic-net/sonic-platform-common#521 (comment) here at sff_mgr PR, regarding whether setting power_override bit should be included as part of handle_high_power_class:
There was a problem hiding this comment.
high power class enabling (added by this PR) and lpmode turning-off are two different independent steps. Not all modules need high power class enabling(only for power_class>=5), while most of the optical modules need lpmode turning-off.
Today, power_override bit setting has already been done by sff_mgr's lpmode turning-off (as part of which, xcvr API set_lpmode() gets called setting power_override bit). There's no need to do extra setting for that bit as part of high power class enabling.
Also from functionality POV, would it make more sense to decouple power_override bit from handling of high_power_class? Because, according to the truth table 6-11, once high power class (byte 93 bit 2 or/and bit 3) gets set properly, the module will function in the desired power class after the module is brought out of lpmode by either HW control or SW control.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Add xcvrd/sff_mgr support for enabling high power class if module's power class is greater or equal to 5 (Refer to SFF-8636 spec 6.2.6 Control Functions (Page 00h, Bytes 86-99) for byte 93 definition)
Change
enable_sff_mgrflag toenable_sff_mgr_controlled_tx, so that sff_mgr will always get spawned by default, and all platforms/vendors by default can get the benefit of high power class enabling/etc. Only sff_mgr's controlling on module Tx is platform based (enable_sff_mgr_controlled_tx)Motivation and Context
Without enabling high power class for those modules, the module won't operate properly with power output and link won't come up.
How Has This Been Tested?
Verified the module operate with proper power output.
Additional Information (Optional)