Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PSU key to use get_name API instead of index #446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change PSU key to use get_name API instead of index #446

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f31a6df
psu key to use get_name api if available
gregoryboudreau Mar 11, 2024
3e71901
Merge branch 'master' into psu_key_names
gregoryboudreau Mar 26, 2024
677642a
modifications for tests
gregoryboudreau Jul 8, 2024
29ec8d2
Merge branch 'sonic-net:master' into psu_key_names
gregoryboudreau Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sonic-psud/scripts/psud
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ def _wrapper_get_psu_status(psu_index):
#

def get_psu_key(psu_index):
if platform_chassis is not None:
try:
return platform_chassis.get_psu(psu_index - 1).get_name()
Copy link
Contributor

@judyjoseph judyjoseph Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen many platform drivers implementing the name as below

device = "PSU{}".format(self.psu_index)

no space between PSU and [index]

while PSU_INFO_KEY_TEMPLATE is of the format "PSU [index]". There is a space after PSU substring

Is this ok ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change would allow for both. If a vendor has defined the get_name() api it will fall back to the original implementation of the enumerated index based name (full key: "PSU_INFO|PSU 1" for example). With the get name api implemented though the vendor gets full determination of this name: (full key: "PSU_INFO|PSU0" or "PSU_INFO|psutray0.psu0" for example).

except NotImplementedError:
pass
return PSU_INFO_KEY_TEMPLATE.format(psu_index)


Expand Down
Loading