-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PSU key to use get_name API instead of index #446
Open
gregoryboudreau
wants to merge
4
commits into
sonic-net:master
Choose a base branch
from
gregoryboudreau:psu_key_names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f31a6df
psu key to use get_name api if available
gregoryboudreau 3e71901
Merge branch 'master' into psu_key_names
gregoryboudreau 677642a
modifications for tests
gregoryboudreau 29ec8d2
Merge branch 'sonic-net:master' into psu_key_names
gregoryboudreau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen many platform drivers implementing the name as below
no space between PSU and [index]
while PSU_INFO_KEY_TEMPLATE is of the format "PSU [index]". There is a space after PSU substring
Is this ok ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change would allow for both. If a vendor has defined the get_name() api it will fall back to the original implementation of the enumerated index based name (full key: "PSU_INFO|PSU 1" for example). With the get name api implemented though the vendor gets full determination of this name: (full key: "PSU_INFO|PSU0" or "PSU_INFO|psutray0.psu0" for example).