Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Thinkit] Remove ability to set P4Info.Fix issue with punt expectations. Add AclDeny to ingress security table and check if the packets get dropped. Update to push a SUT P4Info if given one.Remove if (!params.punt_action.has_value()) in acl_feature_test. Make rewrites explicit in ACL feature test.Add a test to match on src_mac in AclEgressTable #1015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ksravani-hcl
Copy link
Contributor

Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 695 targets (0 packages loaded, 0 targets configured).
INFO: Found 695 targets...
INFO: Elapsed time: 0.760s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 695 targets (0 packages loaded, 0 targets configured).
INFO: Found 477 targets and 218 test targets...
INFO: Elapsed time: 253.458s, Critical Path: 121.97s
INFO: 275 processes: 330 linux-sandbox, 18 local.
INFO: Build completed successfully, 275 total actions
//dvaas:port_id_map_test PASSED in 0.8s
//dvaas:test_run_validation_golden_test PASSED in 0.1s
//dvaas:test_run_validation_test PASSED in 0.6s
//dvaas:test_run_validation_test_runner PASSED in 0.0s
//dvaas:test_vector_stats_diff_test PASSED in 0.0s
//dvaas:test_vector_stats_test PASSED in 0.0s
//dvaas:test_vector_test PASSED in 0.6s
//dvaas:user_provided_packet_test_vector_diff_test PASSED in 0.1s
//dvaas:user_provided_packet_test_vector_test PASSED in 0.1s
//gutil:collections_test PASSED in 0.5s
//gutil:io_test PASSED in 0.5s
//gutil:proto_matchers_test PASSED in 0.7s
//p4rt_app/tests:role_test PASSED in 1.5s
//p4rt_app/tests:state_verification_test PASSED in 3.2s
//p4rt_app/tests:vrf_table_test PASSED in 2.7s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.6s
//p4rt_app/utils:table_utility_test PASSED in 0.8s
//sai_p4/instantiations/google:clos_stage_test PASSED in 0.5s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.5s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.6s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.1s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 0.6s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.0s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.4s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 1.0s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.5s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 0.8s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.3s
//tests/forwarding:hash_statistics_util_test PASSED in 0.9s
//tests/lib:p4info_helper_test PASSED in 0.8s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 0.8s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 0.1s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.1s
//tests/sflow:sflow_util_test PASSED in 6.9s
//thinkit:bazel_test_environment_test PASSED in 0.6s
//thinkit:generic_testbed_test PASSED in 1.0s
//thinkit:mock_control_device_test PASSED in 0.5s
//thinkit:mock_generic_testbed_test PASSED in 0.7s
//thinkit:mock_mirror_testbed_test PASSED in 0.6s
//thinkit:mock_ssh_client_test PASSED in 0.0s
//thinkit:mock_switch_test PASSED in 0.7s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.7s
//tests/lib:packet_generator_test PASSED in 56.7s
Stats over 4 runs: max = 56.7s, min = 55.9s, avg = 56.5s, dev = 0.4s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 1.8s
Stats over 5 runs: max = 1.8s, min = 0.8s, avg = 1.4s, dev = 0.4s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 44.5s
Stats over 50 runs: max = 44.5s, min = 0.8s, avg = 1.9s, dev = 6.1s

Executed 218 out of 218 tests: 218 tests pass.
INFO: Build completed successfully, 275 total actions

@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl
Copy link
Contributor Author

Co-authored-by: Jonathan Dilorenzo dilo@google.com
Co-authored-by: Srikishen Pondicherry Shanmugam kishanps@google.com

@ksravani-hcl ksravani-hcl changed the title [Thinkit] Add a test to match on src_mac in AclEgressTable [Thinkit] Remove ability to set P4Info.Fix issue with punt expectations. Add AclDeny to ingress security table and check if the packets get dropped. Update to push a SUT P4Info if given one.Remove if (!params.punt_action.has_value()) in acl_feature_test. Make rewrites explicit in ACL feature test.Add a test to match on src_mac in AclEgressTable Feb 14, 2025
@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from df9e24c to 16ce1e5 Compare February 14, 2025 08:50
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 16ce1e5 to 928b370 Compare February 14, 2025 15:23
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 928b370 to 55a8e20 Compare February 16, 2025 17:17
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 55a8e20 to 8f31bba Compare February 17, 2025 13:57
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 8f31bba to 03206c4 Compare February 17, 2025 14:20
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 03206c4 to c00d0e9 Compare February 18, 2025 11:16
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

Copy link

@jaanah-hcl jaanah-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishanps Kindly review the PR
Thanks

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from c00d0e9 to 33f3408 Compare February 19, 2025 13:41
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@kishanps
Copy link
Collaborator

@ksravani-hcl Pls fix conflicts

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 33f3408 to bccba99 Compare February 25, 2025 06:45
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from bccba99 to 096038a Compare February 25, 2025 06:52
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@jaanah-hcl
Copy link

@kishanps Merge conflicts are fixed and build passed, please review the PR

…ns. Add AclDeny to ingress security table and check if the packets get dropped. Update to push a SUT P4Info if given one.Remove `if (!params.punt_action.has_value())` in acl_feature_test. Make rewrites explicit in ACL feature test.Add a test to match on src_mac in AclEgressTable
@ksravani-hcl ksravani-hcl force-pushed the tests_integration_branch_15 branch from 096038a to 09d4b77 Compare March 12, 2025 08:19
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants