Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TSB is saved in config after deploy-mg and during pretest #17247

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

Javier-Tan
Copy link
Contributor

@Javier-Tan Javier-Tan commented Feb 28, 2025

Description of PR

Summary:
Fixes #17246

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest

How did you do it?

Add config save after TSB is executed

How did you verify/test it?

Output tsa_enabled before and after pretest to make sure it is working is intended

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

Sorry, something went wrong.

* Add config save after performing TSB in pretest

Signed-off-by: Javier Tan javiertan@microsoft.com
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Javier-Tan Javier-Tan requested a review from arlakshm February 28, 2025 03:16
@Javier-Tan Javier-Tan changed the title Ensure TSB is in golden config Ensure TSB is saved in config when test_startup_tsa_tsb is disabled Feb 28, 2025
@Javier-Tan
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

linux-foundation-easycla bot commented Mar 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

… deploy-mg

* Execute TSB before config save during deploy-mg

Signed-off-by: Javier Tan javiertan@microsoft.com
@Javier-Tan Javier-Tan force-pushed the pretest_tsb_config_save branch from af50809 to 34862d4 Compare March 4, 2025 09:37
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Javier-Tan Javier-Tan changed the title Ensure TSB is saved in config when test_startup_tsa_tsb is disabled Ensure TSB is saved in config after deploy-mg and during pretest Mar 4, 2025
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#172

amulyan7 pushed a commit to amulyan7/sonic-mgmt that referenced this pull request Mar 31, 2025
…ic-net#17247)

What is the motivation for this PR?
Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest

How did you do it?
Add config save after TSB is executed

How did you verify/test it?
Output tsa_enabled before and after pretest to make sure it is working is intended

Signed-off-by: Javier Tan javiertan@microsoft.com
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 31, 2025
…ic-net#17247)

What is the motivation for this PR?
Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest

How did you do it?
Add config save after TSB is executed

How did you verify/test it?
Output tsa_enabled before and after pretest to make sure it is working is intended

Signed-off-by: Javier Tan javiertan@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New deploy-mg causes TSA to be in config_db (and golden), causing test errors when startup_tsa_tsb is disabled
3 participants