Replace ExaBGP v3 and v4 flask based process API with tornado #16834
+33
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
opcoder0
requested review from
wangxin,
yejianquan,
yutongzhang-microsoft and
xwjiang-ms
wangxin
approved these changes
Mar 5, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
amulyan7
pushed a commit
to amulyan7/sonic-mgmt
that referenced
this pull request
Mar 31, 2025
…net#16834) Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
Merge after sonic-net/sonic-buildimage#21655
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.
How did you do it?
Replace ExaBGP process API with Tornado app.
How did you verify/test it?
Ran add, remove topology to check announce routes
Ran route stress test to verify it is stable
Any platform specific information?
None
Supported testbed topology if it's a new test case?
NA
Documentation
NA