Fix an error of checking reboot type. #14155
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang-ms
approved these changes
Aug 19, 2024
opcoder0
reviewed
Aug 19, 2024
| @@ -344,7 +344,9 @@ def get_reboot_cause(dut): | |||
| # is such like "User issued 'xxx' command [User: admin, Time: Sun Aug 4 06:43:19 PM UTC 2024]" | |||
| # So, use the above pattern to get real reboot cause | |||
| if dut.facts["asic_type"] == "vs": | |||
| cause = re.search("User issued '(.*)' command", cause).groups()[0] | |||
| match = re.search("User issued '(.*)' command", cause) | |||
There was a problem hiding this comment.
@yutongzhang-microsoft since KVM prints something like this for "show reboot-cause" on the first boot -
Unknown (First boot of SONiC version master.597250-dc3c0451b)
The above regex User issued ... won't match the above string. Won't you need one more regex Unknown (\(.*\)) to match the above?
There was a problem hiding this comment.
Because, the pattern User issued '(.*)' command will get the real reboot reason in the position of (.*), such as warm-reboot, fast-reboot. But if we get the string Unknown (First boot of SONiC version master.597250-dc3c0451b), we can't match the cause of dict reboot_ctrl_dict in this file. So I think just return REBOOT_TYPE_UNKNOWN makes sence.
There was a problem hiding this comment.
Thank you I see what you mean. LGTM
wangxin
approved these changes
Aug 19, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? There is another reboot cause Unknown (First boot of SONiC version xxx) on kvm besides User issued xxx' command, which will cause error 'NoneType' object has no attribute 'groups' based on the current code. To address this, this PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue. How did you do it? This PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue. How did you verify/test it?
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
What is the motivation for this PR? There is another reboot cause Unknown (First boot of SONiC version xxx) on kvm besides User issued xxx' command, which will cause error 'NoneType' object has no attribute 'groups' based on the current code. To address this, this PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue. How did you do it? This PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue. How did you verify/test it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
There is another reboot cause
Unknown (First boot of SONiC version xxx)on kvm besidesUser issued xxx' command, which will cause error'NoneType' object has no attribute 'groups'based on the current code. To address this, this PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue.Summary:
Fixes # (13979
)
Type of change
Back port request
Approach
What is the motivation for this PR?
There is another reboot cause
Unknown (First boot of SONiC version xxx)on kvm besidesUser issued xxx' command, which will cause error'NoneType' object has no attribute 'groups'based on the current code. To address this, this PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue.How did you do it?
This PR suggests a conditional check to ensure that the match object is not None before attempting to access its 'groups' attribute, thereby preventing such issue.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation