[Yang] Add Vnet Support for Interface #21956
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Do you have a HLD PR to explain the big picture? What is the motivation of this PR? |
Hi @qiluo-msft, I don't have a HLD PR. My manager Anish @anish-n told me to do that. Here is his original words: If this doesn't make sense, let me know and I will check with him. Thanks! |
|
@qiluo-msft here is the HLD for vnet/vxlan https://github.com/sonic-net/SONiC/blob/gh-pages/doc/vxlan/Vxlan_hld.md. We will be configuring vlan subinterfaces within a vnet as detailed by the above HLD. Do let me know if you have any further questions on the use case etc! |
src/sonic-yang-models/tests/yang_model_tests/tests/vlan_sub_interface.json
Outdated
Show resolved
Hide resolved
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
unit test failed: ERROR YANG-TEST:test_yang_model.py:72 Failed to load file ./tests/yang_model_tests/tests/interface.json |
Hi Gang, Thank you for reviewing! The unit tests failed because of merge issue. Previously, my changes have resulted in successful pipeline runs, see: 2d77a95. (Only one testbed failed out of automatic cancellation due to running over 240 minutes.) I will push latest changes in minutes. Many thanks again! |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@ganglyu Hi Gang! I have fixed the unit tests, could you please check this pr again? Many thanks! |
|
/azp run Azure.sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 21956 in repo sonic-net/sonic-buildimage |
Why I did it
vnet_namesupport is required to be added in INTERFACE, VLAN_SUB_INTERFACE, VLAN tables, but YANG models have never been updated to reflect that change. Updated yang model and added more test cases to reflect the change.Work item tracking
How I did it
vnet_nametosonic-interface,sonic-vlan,sonic-vlan-sub-interface, type as leafref path to thesonic-vnetmodelvnet_nameHow to verify it
cd src/sonic-yang-models && python3 setup.py testtest_configs tests passed
sample_config_db.json passed (Ignore the assertion error)
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)