-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Queue mappings and WRED profile updates #21951
base: master
Are you sure you want to change the base?
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Will test this PR |
"scheduler": "scheduler.1" | ||
"scheduler": "scheduler.22" | ||
}, | ||
"{{ port }}|8": { | ||
"scheduler": "scheduler.1" | ||
"scheduler": "scheduler.22" | ||
}, | ||
"{{ port }}|9": { | ||
"scheduler": "scheduler.1" | ||
"scheduler": "scheduler.22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only diff between the SKUs, was this intentional?
Other than that, I tested this PR and it LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rick-arista WRED profile template values could change, so created separate qos.json.j2 for 2 SKUs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Just confirming it was intentional that for ports 7, 8, 9 in the templates its scheduler.22
for the C224, and scheduler.4
for the C256
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rick-arista , that was typo. We will keep the scheduler configs same for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These would be for queues 7,8,9 on all the ports.
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Update DSCP-->TC-->Queue mappings for TH5 SKU
Work item tracking
31688395
How I did it
Modified qos.json.j2 file to include WRED profiles for the additional queues.