Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-sonic-mgmt] Add dash-pipeline-utils #21919

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimmyzhai
Copy link
Contributor

@jimmyzhai jimmyzhai commented Mar 4, 2025

Why I did it

DASH test cases need package dash-pipeline-utils, which supports dash underlay routing configuration.

Work item tracking
  • Microsoft ADO: 31720866

How I did it

Include package dash-pipeline-utils in docker image docker-sonic-mgmt

How to verify it

$ docker run --rm -it docker-sonic-mgmt:latest bash
junhuazhai@438cb686e496:~$ pip list | grep dash-pipeline-utils
dash-pipeline-utils              1.0

junhuazhai@438cb686e496:~$ python
Python 3.8.10 (default, Feb  4 2025, 15:02:54)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import dash_pipeline_utils
>>> dash_pipeline_utils.__file__
'/usr/local/lib/python3.8/dist-packages/dash_pipeline_utils.py'
>>>
junhuazhai@438cb686e496:~$

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Pull request contains merge conflicts.

@jimmyzhai jimmyzhai force-pushed the dash_pipeline_utils branch from 765f455 to 0e00fd6 Compare March 5, 2025 01:05
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai jimmyzhai requested review from Pterosaur and r12f March 6, 2025 08:40
# Install dash-pipeline-utils
COPY ["files/github_get.py", "/usr/bin"]
RUN cd /tmp \
&& python3 /usr/bin/github_get.py https://api.github.com/repos/sonic-net/DASH/contents/dash-pipeline/utils \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we add the commit id here in this PR?

Copy link
Contributor

@Pterosaur Pterosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -35,6 +35,9 @@ $(COPP_CONFIG_TEMPLATE)_PATH = files/image_config/copp
RSYSLOG_PLUGIN_CONF_J2 = rsyslog_plugin.conf.j2
$(RSYSLOG_PLUGIN_CONF_J2)_PATH = files/build_templates

GITHUB_GET = github_get.py
$(GITHUB_GET)_PATH = scripts
Copy link
Contributor

@Pterosaur Pterosaur Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is this line useful? I don't see this variable to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants