-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-sonic-mgmt] Add dash-pipeline-utils #21919
base: master
Are you sure you want to change the base?
Conversation
/azp run Azure.sonic-buildimage |
Pull request contains merge conflicts. |
765f455
to
0e00fd6
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
# Install dash-pipeline-utils | ||
COPY ["files/github_get.py", "/usr/bin"] | ||
RUN cd /tmp \ | ||
&& python3 /usr/bin/github_get.py https://api.github.com/repos/sonic-net/DASH/contents/dash-pipeline/utils \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we add the commit id here in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -35,6 +35,9 @@ $(COPP_CONFIG_TEMPLATE)_PATH = files/image_config/copp | |||
RSYSLOG_PLUGIN_CONF_J2 = rsyslog_plugin.conf.j2 | |||
$(RSYSLOG_PLUGIN_CONF_J2)_PATH = files/build_templates | |||
|
|||
GITHUB_GET = github_get.py | |||
$(GITHUB_GET)_PATH = scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this line useful? I don't see this variable to be used.
Why I did it
DASH test cases need package dash-pipeline-utils, which supports dash underlay routing configuration.
Work item tracking
How I did it
Include package dash-pipeline-utils in docker image docker-sonic-mgmt
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)