[docker-sonic-mgmt] Add dash-pipeline-utils #21919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
|
Pull request contains merge conflicts. |
jimmyzhai
force-pushed
the
dash_pipeline_utils
branch
from
765f455 to
0e00fd6
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Mar 7, 2025
r12f
reviewed
Mar 7, 2025
| # Install dash-pipeline-utils | ||
| COPY ["files/github_get.py", "/usr/bin"] | ||
| RUN cd /tmp \ | ||
| && python3 /usr/bin/github_get.py https://api.github.com/repos/sonic-net/DASH/contents/dash-pipeline/utils \ |
There was a problem hiding this comment.
Will we add the commit id here in this PR?
Pterosaur
reviewed
Mar 13, 2025
| @@ -35,6 +35,9 @@ $(COPP_CONFIG_TEMPLATE)_PATH = files/image_config/copp | |||
| RSYSLOG_PLUGIN_CONF_J2 = rsyslog_plugin.conf.j2 | |||
| $(RSYSLOG_PLUGIN_CONF_J2)_PATH = files/build_templates | |||
|
|
|||
| GITHUB_GET = github_get.py | |||
| $(GITHUB_GET)_PATH = scripts | |||
There was a problem hiding this comment.
Just curious, is this line useful? I don't see this variable to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
DASH test cases need package dash-pipeline-utils, which supports dash underlay routing configuration.
Work item tracking
How I did it
Include package dash-pipeline-utils in docker image docker-sonic-mgmt
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)